lexdem added a comment.

  In https://phabricator.kde.org/D7848#146378, @aacid wrote:
  
  > Did you upload a wrong diff?
  
  
  Sorry for such a mess. First time commiting

INLINE COMMENTS

> aacid wrote in part.cpp:2206
> Why commented code?

Actually, not sure, if need this lines. Okay, I'll remove, since it works 
without it

> aacid wrote in part.cpp:2187
> Any reason you're not just calling
> 
> BookmarkManager::removeBookmark( const DocumentViewport &vp );
> 
> ?

Just checked with that. It works, but on my machine there were some "slow 
responding". Not sure, if it just because of lot memory used. But anyway, here 
goes new diff

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7848

To: lexdem, #okular
Cc: aacid

Reply via email to