aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land.
Whoever decided to change from iconName to fullpath deserves some punishment for having a class constructor that has exactly signature but behaves totally different. every single instance is broken https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082 https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147 https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162 https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140 meh, i'll forget this to make my life better. REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D7996 To: elvisangelaccio, #okular, aacid Cc: aacid, #okular
