https://bugs.kde.org/show_bug.cgi?id=182994
Nate Graham <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/oku | |lar/6b5a7c9a1a00dec994cfb03 | |b0abf369539168758 --- Comment #7 from Nate Graham <[email protected]> --- Git commit 6b5a7c9a1a00dec994cfb03b0abf369539168758 by Nathaniel Graham. Committed on 01/10/2017 at 01:45. Pushed by ngraham into branch 'master'. Custom background color Summary: Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users). Reasons for this change: Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology). Many people want this change occording to Bugzilla and other sources. Maintenance: Nearly no additional maintenance: This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular. {F4257766} Other less important information: https://git.reviewboard.kde.org/r/130219/ https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html Test Plan: Tested everything, it all works: Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color). Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham Reviewed By: ngraham Subscribers: aacid, ltoscano, ngraham Tags: #okular Differential Revision: https://phabricator.kde.org/D8051 M +2 -2 CMakeLists.txt M +7 -0 conf/dlggeneral.cpp M +3 -0 conf/dlggeneral.h M +59 -2 conf/dlggeneralbase.ui M +5 -0 conf/okular.kcfg M +6 -1 ui/pageview.cpp https://commits.kde.org/okular/6b5a7c9a1a00dec994cfb03b0abf369539168758 -- You are receiving this mail because: You are the assignee for the bug.
