aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular.
REVISION SUMMARY As explained in the comment we can do with using an older Qt since what this adds is really a small nicety in a corner case Give warnings when the file is modified externally Unfortunately, poppler (the only backed that supports saving) is not able to save properly if the file is modified by a third party while it is opened So we give the user a warning saying things went wrong and give him the option to not reload/close, that way if there was something very important in the annotations she added she can try to save them (even if by copy&paste the contents to a third program) REPOSITORY R223 Okular BRANCH file_modified_externally REVISION DETAIL https://phabricator.kde.org/D8863 AFFECTED FILES core/document.cpp part.cpp part.h To: aacid Cc: #okular, ngraham, aacid