dileepsankhla created this revision.
dileepsankhla added a reviewer: aacid.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
dileepsankhla requested review of this revision.

REVISION SUMMARY
  When running okular with the parameter --print to directly open the print 
mode, it doesn't exit after acknowledging the print dialog. Hence adding 
--print_and_exit option exits okular 
  after ackowledging the print dialog and thus useful for command line batch 
processing or a Dolphin service as the issue suggests.
  
  BUG: 318998

TEST PLAN
  1. open a file in Okular using the parameter --print. It will open Okular in 
print mode with the print dialog
  2. Either print the file or cancel the print dialog
  3. You will find that Okular stays open
  4. Now using this patch, see for available options with the --help parameter. 
You will find --print_and_exit option
  5. Now open a file in Okular using the parameter --print_and_exit. It will 
open Okular in print mode with the print dialog
  6. Either print the file or cancel the print dialog
  7. You will find that Okular closes after acknowledging the dialog

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10249

AFFECTED FILES
  autotests/mainshelltest.cpp
  part.cpp
  part.h
  shell/main.cpp
  shell/shell.cpp
  shell/shellutils.cpp
  shell/shellutils.h

To: dileepsankhla, aacid
Cc: ngraham, aacid, #okular, michaelweghorn

Reply via email to