> On July 21, 2016, 9:19 a.m., Olivier Churlaud wrote: > > ui/searchlineedit.cpp > > Lines 219 (patched) > > <https://git.reviewboard.kde.org/r/125442/diff/1/?file=408641#file408641line219> > > > > Before submitting patches, check with a `git diff` that you don't add > > whitespaces...
I've migrated this patch to Phabricator and cleaned up the whitespace issues. https://phabricator.kde.org/D10298 - Nathaniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125442/#review97696 ----------------------------------------------------------- On Sept. 29, 2015, 5:42 a.m., Fahad Al-Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125442/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 5:42 a.m.) > > > Review request for Okular. > > > Bugs: 207748 > http://bugs.kde.org/show_bug.cgi?id=207748 > > > Repository: okular > > > Description > ------- > > Since arabic search does not work properly in all but pdf backends, this is > a quick attempt to fix this problem. I assumed that text in okular document > is in the logical order[ it is a bug by itself]. So by mirroring the search > text, the search function works again. > > The limitation: > - you can not search arabic and english text together. > > Future work: > we need to check that text generated by poppler is placed in Visual order, so > when we copy it and paste it in text editor is still readable. > > > Diffs > ----- > > ui/searchlineedit.cpp c736759 > > > Diff: https://git.reviewboard.kde.org/r/125442/diff/1/ > > > Testing > ------- > > Tested in Arabic & Hebrew pdfs and it works fine. > > > Thanks, > > Fahad Al-Saidi > >