aheinecke added inline comments. INLINE COMMENTS
> aacid wrote in document.cpp:1153 > I was thinking, can't we do setText emit the signal? so we don't really need > to worry about forgetting to emit refreshFormWidget in case we end up > implementing another function or something that does change the text of a > form? Sure this would be nice but as I understand it this would mean making FormFieldText (or the general FormField) a QObject. As this is public API i shied away from such a solution. Should I change the patch to make FormFieldText a QObject with a textChanged signal? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10048 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham
