aacid added a comment.

  Thanks for trying to fix this :)
  
  Commented code should not be there.
  
  this needs an autotest though to make sure we don't break it in the future
  
  Are you sure this needs to be done at this level? i.e. have you tried this on 
xps/chm/djvu/dvi with RTL text to make sure you're not breaking that?
  
  Also, in the poppler bug you mentioned this should happen in poppler, and now 
you're making a patch for okular, will you close the bug in poppler then? Or 
should this happen in poppler?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

Reply via email to