fahadalsaidi added a comment.
@aacid Thanks for the feedback. > I'm still unconvinced the text reversion is happening at the proper level. I really a new to okular's code, so please guide me to the right direction. > And you have a memory leak in your function as reported by valgrind shows that the leak happen in: makeWordFromCharacters(QList<TinyTextEntity*> const&, int, int) (textpage.cpp:1209) which needs to be fix but not in this patch since it is irrelevant to it. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10455 To: fahadalsaidi, #okular, aacid, ltoscano Cc: ngraham, michaelweghorn, aacid