aacid added inline comments.

INLINE COMMENTS

> chinmoyr wrote in signaturewidgets.cpp:158
> Well it's the result of taking your advice of "do what adobe does" bit too 
> far.
> Just curious, why is it bad? Because you can only see elided text? Are there 
> other reasons?

So how do you know 450x400 is going to fit with my big fonts and the text in 
Catalan instead of English?

> chinmoyr wrote in signaturewidgets.cpp:171
> Because adobe reader has a read only textedit.

It's interesting, if you look at Firefox, it uses a label in one place and what 
seems to be a textedit in another, meh.

> chinmoyr wrote in signaturewidgets.cpp:215
> Even here I copied adobe.

Yeah.... let's not copy bad UI behaviour

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13483

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

Reply via email to