sander added inline comments.
INLINE COMMENTS
> dileepsankhla wrote in annots.cpp:182
> I have added the following lines in generator/poppler/CMakeLists.txt:
>
> check_cxx_source_compiles("
> #include <poppler-qt5.h>
> #include <QColor>
> int main()
> {
> Poppler::TextAnnotation *annot = new Poppler::TextAnnotation(
> Poppler::TextAnnotation::InPlace );
> annot->setTextColor(Qt::blue);
> return 0;
> }
> " HAVE_POPPLER_0_67)
>
> The typewriter text is created with the desired color but whenever I move the
> annotation, the text color falls back to "black". It means in
> ```PopplerAnnotationProxy::notifyModification```,
> ```ppl_txtann->setTextColor( okl_txtann->textColor() );``` is never get
> called. Why is this happening even after setting the flag in both
> CMakeLists.txt and annots.cpp?
Is the flag really set (check in
build/generators/poppler/config-okular-poppler.h)? If not: throw away the
content of your 'build' directory and try again from scratch.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D13203
To: dileepsankhla, tobiasdeiminger
Cc: sander, ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
