tobiasdeiminger accepted this revision. tobiasdeiminger added a comment. This revision is now accepted and ready to land.
Here's a PDF <https://bugs.kde.org/attachment.cgi?id=71098> and LaTex source <https://bugs.kde.org/attachment.cgi?id=71099>, suitable to trigger and test OkularLinkType::setAnnotation in resolveMediaLinks. Everything still works fine if patch is applied: 1. Video starts automatically in presentation mode, before and after highlighting + ctrl-s 2. Watching this procedure with valgrind shows no memory leaks So here's an approve from my side, thanks Albert for the patch. (video doesn't autostart in page view mode, no matter if patch is applied or not - should it?) REPOSITORY R223 Okular BRANCH arcpatch-D14752 REVISION DETAIL https://phabricator.kde.org/D14752 To: aacid, tobiasdeiminger Cc: tobiasdeiminger, sander, okular-devel, ngraham, aacid
