tobiasdeiminger created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. tobiasdeiminger requested review of this revision.
REVISION SUMMARY First check in RegularArea::isNull sais this: "I'm a QList. If I'm empty, I'm not null". That doesn't make sense, invert it. The next check says: "If I contain at least one shape which is not null, I'm not null.". That makes sense, keep it. TEST PLAN - check for regression in callers (TextPage::findText, TextPage::text, TextPage::words) REPOSITORY R223 Okular BRANCH fix_regulararea_isnull REVISION DETAIL https://phabricator.kde.org/D15344 AFFECTED FILES core/area.h To: tobiasdeiminger Cc: okular-devel, ngraham, aacid
