tobiasdeiminger marked 8 inline comments as done. tobiasdeiminger added a comment.
This revision should be quite complete now. AnnotWindow::reloadInfo `if ( m_annot->subType() == Okular::Annotation::AText )` seems like a wrong place to do special typewriter handling (make popup dialog pastel yellow), but I had no better idea. Guess it's not worth the while to invent some derived TypewriterAnnotWindow, because typewriter should get a complete different UI as midterm goal anyway. Any suggestion? And I've got an open question: What is the original intention of the `engine [color]` attribute from tools.xml? Enrico Ros introduced it 13 years ago, but I see no reason why we couldn't get along with solely the `annotation [color]` attributes. As far as I can tell, engine color is always in sync with annotation [color], therefore it's redundant, and it's not clear when to use what. I'm ignoring it for typewriter for now. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15204 To: tobiasdeiminger Cc: sander, okular-devel, ngraham, aacid
