aacid added a comment.

  > There is one drawback to this patch. With the cursor mode HiddenDelay, the 
cursor disappears after a short time, and should reappear at the next mouse 
move. This does not work if the cursor has been hidden by TabletLeaveProximity, 
and I don't understand why.
  
  Didn't we have this discussion millions of years ago? Maybe it was with 
someone else.
  
  I Have two theories:
   a) You're interfering with KCursor autohide, according to KCursor the cursor 
is still visible because it's you that set it to blank, not KCursor itself, so 
KCursor doesn't see a need to show it because it already thinks it's shown.
   b) You need to call KCursos::autoHideEventFilter in your new event filter, 
see KCursor documentation 
https://api.kde.org/frameworks/kwidgetsaddons/html/classKCursor.html#ac667325a07f50c210d728d1ebddbcd06

INLINE COMMENTS

> sander wrote in presentationwidget.cpp:1373
> It is. The code I added is exactly what the two calls to 
> `slotChangeDrawingToolEngine` do, except that the first one additionally set 
> the cursor to 'Arrow' (without good reason).
> 
> If you want this documented better then it may be a good idea to have it in a 
> separate patch.

ok

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17929

To: sander, #okular
Cc: shubham, aacid, ngraham, okular-devel, darcyshen

Reply via email to