michaelweghorn updated this revision to Diff 49518. michaelweghorn added a comment.
Implement improvements suggested by Albert: - use an enum rather than a bool for scale mode - avoid ABI breakage by adding extra methods that take an additional parameter for scale mode and make existing methods call those What's a bit ugly here is that 'scaleMode' cannot be the last parameter in the new 'FilePrinter::printFile' method, as it has to come before those params that have a default value. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18179?vs=49225&id=49518 BRANCH michaelweghorn/UPDATE_20191115_D18179_allowScaledPrintingWithoutRasterization REVISION DETAIL https://phabricator.kde.org/D18179 AFFECTED FILES core/fileprinter.cpp core/fileprinter.h generators/poppler/generator_pdf.cpp To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen
