aacid added inline comments. INLINE COMMENTS
> michaelweghorn wrote in document.h:728 > I have changed the return type to a QWidget* again, but only for the Document > class itself, not in the other places. As far as I understand, this place > here is the only one relevant for the ABI. Is this correct? > > Currently, there is no complaint if a plain QWidget* is returned, it's just > handled as it used to be then. Should I change that (e.g. emit a > 'qWarning()')? interfaces/ is also installed when doing make install so compatibility there is also important. Since you have a dynamic cast in part.cpp i guess it makes sense to have a warning when the dynamic cast fails? Telling the "developer" that he should update her implementation of the method? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, darcyshen
