aacid added a comment.
In D18744#441906 <https://phabricator.kde.org/D18744#441906>, @davidhurka wrote: > In D18744#438675 <https://phabricator.kde.org/D18744#438675>, @shubham wrote: > > > Do not delete area > > > Interestingly, setPageTextSelection() deletes area (without making it nullptr). Shouldn’t this side effect be documented (in another patch)? Sure if you want to create a patch that documents it, feel free (BTW it can't set the pointer to null for the caller, that's not how pointers work) INLINE COMMENTS > davidhurka wrote in pageview.cpp:5587 > The other selection tools copy to clipboard. Maybe Select All should do so > too, because the selection can not be used any other way than Menu -> Edit -> > Copy. (Other way: e. g. right click -> Search With DuckDuckGo) Not convinced, for example kate doesn't do that either. open kate, type something, press ctrl+a to select it, it only gets selected, not copied to the clipboard but if you select it with the mouse it then gets copied to the clipboard. It'd be the same we're doing, so i think this consistency is good to maintain. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
