aacid added inline comments. INLINE COMMENTS
> fileprinter.h:58 > + * > + * @since 1.7 > + */ the since will need to be 1.8 (and all the other 1.7 you added) > fileprinter.h:61 > + enum ScaleMode { > + None = 0, > + FitToPrintArea = 1 Make this no Scale or something similar since otherwise FilePrinter::None seems like you're saying "none printer" REPOSITORY R223 Okular BRANCH michaelweghorn/UPDATE_D18179 REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen