sander added a comment.
I like the color part of this patch. As for the line width: As mentioned, '3' is arbitrary. You need to find a width that takes current dpi into account. Ideally, the width should be what later gets written into the pdf file. The fact that the rectangle is currently not completely drawn sounds like a Qt bug. What is the pen width without your patch? Even if it has width 0 it should paint a 1-pixel line. Or is the page downscaled somewhere after rendering? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular-devel, ngraham Cc: sander, aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen
