pino added inline comments. INLINE COMMENTS
> annotationwidgets.cpp:549-558 > + m_termStyleCombo->addItem( QStringLiteral(u"\u25A1") + i18n( " Square" ) > ); > + m_termStyleCombo->addItem( QStringLiteral(u"\u25CB") + i18n( " Circle" ) > ); > + m_termStyleCombo->addItem( QStringLiteral(u"\u25C7") + i18n( " Diamond" > ) ); > + m_termStyleCombo->addItem( QStringLiteral(u"\u2192") + i18n( " Open > Arrow" ) ); > + m_termStyleCombo->addItem( QStringLiteral(u"\u21FE") + i18n( " Closed > Arrow" ) ); > + m_termStyleCombo->addItem( i18n( " None" ) ); > + m_termStyleCombo->addItem( QStringLiteral(u"\u22A3") + i18n( " Butt" ) ); I think this does not play well with translations: there is nothing that says what for the leading spaces are, so translators can easily not have them in the translations, resulting in symbol and first word attached together. There is also the issue that some of the strings are no easy to get, for example "Butt" (yes, without context), or "-/ Slash". My proposal is the following: - create a QIconEngine that draws a specific character/string as icon; this also makes sure all the symbols and texts are properly aligned - leave the strings as simple strings with no spaces nor other parts, adding contexts to them REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular, #vdg, sander, ngraham Cc: pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid
