sander added inline comments.
INLINE COMMENTS
> kjs_document.cpp:139
> +
> + for ( Page * pIt : doc->m_pagesVector )
> + {
As you were using const iterators before: Shouldn't this be
`qAsConst(doc->m_pagesVector)` to avoid unnecessary detaching?
> kjs_document.cpp:142
> + const QLinkedList< Okular::FormField * > pageFields =
> pIt->formFields();
> + numFields += pageFields.size();
> + }
Why not simply `numFields += pIt->formFields()` ?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21202
To: joaonetto, aacid, #okular
Cc: sander, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
