tobiasdeiminger created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
tobiasdeiminger requested review of this revision.

REVISION SUMMARY
  This implements drawing the line endings for 2 point lines in non-PDF 
documents.
  
  Implemented:
  
  - Square, Diamond, OpenArrow, ClosedArrow, ROpenArrow, RClosedArrow
  - for start and stop style (start can't be configured in GUI yet)
  - filled or not (fill color can't be configured in GUI yet)
  - with or without leader line
  
  TODO:
  
  - Circle, Butt, Slash
  - shorten main segment
  - Is there an existing class for affien matrix operations? If so, reuse it 
instead of implementing it again.
  - What about multiline annotations?

TEST PLAN
  - open a *.txt document
  - draw line annotations with different arrow styles
  - ... with different leader line settings
  - ... at various angles
  - rotate and scale page

REPOSITORY
  R223 Okular

BRANCH
  feature/drawlineendings

REVISION DETAIL
  https://phabricator.kde.org/D21248

AFFECTED FILES
  ui/pagepainter.cpp
  ui/pagepainter.h

To: tobiasdeiminger
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

Reply via email to