simgunz added a comment.
In D15580#513253 <https://phabricator.kde.org/D15580#513253>, @ngraham wrote: > Some thoughts: > > - Instead of using a horizontal toolbar below the main toolbar, instead I might experiment with a vertical toolbar like the one shown in Gwenview's View mode. We could make the toolbar live inside the Reviews tab, which already shows a list of all annotations (and then we should unify the terminology vis-a-vis "reviews" vs "annotations." REASON: cramming everything into a horizontal toolbar seems impossible for a feature this rich; using a vertical toolbar provides us enough horizontal space to show labels for everything, and enough vertical space to easily hold everything. Also we re-use an existing UI element that's currently rather bare. - How would you fit the annotation actions in the Reviews tab? - Would you create a sub-tab in it (as in Gwenview where the tabs are at the bottom)? - - Can you provide a minimal mockup of this? > > > - Show a button on the toolbar by default that holds the list of favorite annotations, and pre-populate it with the current set of default annotations. Label the button "Quick annotations". At the bottom of the list, add an entry that says something like, "Show advanced annotation settings" that will display the full vertical toolbar in the Reviews tab. REASON: This will make the whole annotations UI much more discoverable. I would rather not cram the "Quick annotations" by populating it with all the basic annotations. The user will end up with the same set of tools in two different places, which is not the point of "Quick annotations". I would instead populate it with 3-4 example custom annotations to illustrate the purpose of that list, putting the likely most used annotations. For example: yellow and green highlighter (to demonstrate we can have two highlighter colors), inline note, popup note, and typewriter. > > > - Remove "Favorites" button from the annotation toolbar (since it'll be on the main toolbar instead) > - Rename "Add to favorites" to say "Add to quick annotations" Ok. > - Given Okular's conservative Frameworks dependency policy, I need to marshall VDG resources ASAP for the icons. Do you have a full list of the icons we need? See bug [[ https://bugs.kde.org/show_bug.cgi?id=408283 | 408283 ] for the rough icon list. Probably we should further discuss the icon design in that bug. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
