[Fwd: Re: [Fwd: Re: Process for Submitting Olio Revisions]]

[Rean Griffith]

Hello Akara,

Attached is a patch addressing some of the issues we have run into and 
"fixed" in our deployments of Olio.

Patch details:

1) *lib/tagcount.rb* has a query that has been optimized for the home 
page.
2) *vendor/plugins/acts_as_taggable/lib/tagging.rb* has been changed to 
  support a counter_cache.
3) *db/migrate/20090713225055_add_counter_cache_to_tags.rb* has been
added to create the counter_cache.

Here are some other issues we've come across that are not resolved in 
the attached patch:

1. *db/schema.rb* is missing from the repository.
2. *users.timezone* has a column size of 25, which is too small for
   "International Date Line West" (28 characters long).
3. Improper checks for the presence of form fields.
   - Currently, Olio uses checks against the empty string (i.e. 
*params[:key] == ""*).
   - This relies on quirks of the gem *rack-0.9.1*, which has been fixed
     in the newest version of rack.
   - The checks should be changed to check for either empty *or* nil
     (i.e. *params[:key].empty? || params[:key].nil?*).
   - One example can be found in *UsersController#new_image?*.

thanks,
Rean


-------- Original Message --------
Subject: Re: [Fwd: Re: Process for Submitting Olio Revisions]
Date: Wed, 29 Jul 2009 14:35:20 -0700
From: Timothy Yung <yungst...@gmail.com>
To: Rean Griffith <r...@eecs.berkeley.edu>
CC: Aaron Beitch <aaron.bei...@gmail.com>
References: <4a70ab8d.5000...@eecs.berkeley.edu>

Attached the patch.

Regards,
Timothy Yung


On Wed, Jul 29, 2009 at 1:05 PM, Rean Griffith 
<r...@eecs.berkeley.edu>wrote:



-------- Original Message --------
Subject: Re: Process for Submitting Olio Revisions
Date: Tue, 28 Jul 2009 17:57:10 -0700
From: Akara Sucharitakul <akara.sucharita...@sun.com>
To: Rean Griffith <r...@eecs.berkeley.edu>
CC: Armando Fox <f...@eecs.berkeley.edu>
References: <4a6f9a10.8080...@eecs.berkeley.edu>

Please just submit the patches to olio-...@incubator.apache.org. We'll
respond and get the fixes committed. Thanks.

-Akara

Rean Griffith wrote:

Hello Akara,

Below are some issues we have come across using the latest version of Olio
including some fixes we have come up with with, what is the process for
reviewing and submitting patches to Olio?

thanks,
Rean

-------- Original Message --------
Subject: Olio Revisions
Date: Tue, 28 Jul 2009 17:19:16 -0700
From: Timothy Yung <yungst...@gmail.com>
To: Rean Griffith <r...@eecs.berkeley.edu>
CC: Aaron Beitch <abei...@berkeley.edu>

I have attached the files that were changed. Here are the issues that the
files address:

  - *lib/tagcount.rb* has a query that has been optimized for the home
  page.
  - *vendor/plugins/acts_as_taggable/lib/tagging.rb* has been changed to
  support a counter_cache.
  - *db/migrate/20090713225055_add_counter_cache_to_tags.rb* has been
added
  to create the counter_cache.

Here are issues that need to be fixed but have not been included in the
attached files.

  1. *db/schema.rb* is missing from the repository.
  2. *users.timezone* has a column size of 25, which is too small for
  "International Date Line West" (28 characters long).
  3. Improper checks for the presence of form fields.
     - Currently, Olio uses checks against the empty string (i.e.
*params[:key]
     == ""*).
     - This relies on quirks of the gem *rack-0.9.1*, which has been fixed
     in the newest version of rack.
     - The checks should be changed to check for either empty *or* nil
     (i.e. *params[:key].empty? || params[:key].nil?*).
     - One example can be found in *UsersController#new_image?*.


Regards,
Timothy Yung