Hi,

There seems to be a regression in BFQ-v7r4,
0002-block-introduce-the-BFQ-v7r4-I-O-sched-for-3.10.patch

bfq_init_queue has the following signature there:
static int bfq_init_queue(struct request_queue *q)

However, it is used as elevator_init_fn callback that requires a different signature (see linux/elevator.h):

typedef int (elevator_init_fn) (struct request_queue *,
                                struct elevator_type *e);

The compiler complains when building the kernel 3.10.40-nrj-desktop:

block/bfq-iosched.c:3774:3: warning: initialization from incompatible pointer type [enabled by default] block/bfq-iosched.c:3774:3: warning: (near initialization for ‘iosched_bfq.ops.elevator_init_fn’) [enabled by default]

The problem, obviously, may lead to kernel crashes.

As far as I can see, BFQ-v7r2 does not have this problem, it defines bfq_init_queue() correctly.

Regards,
Eugene

--
Eugene Shatokhin, ROSA
www.rosalab.com

Reply via email to