On 2014-06-10 23:09, Alexander Khryukin wrote:

Well, patch wget-1.13.3-add-force-clobber-option.patch lead to segfaults on ALL arches
include x86_64

example:

[fedya@lax wget]$ /home/fedya/wget/BUILD/wget-1.15/src/wget --no-content-disposition http://localhost:42481/dummy.html [1]
Aborted (core dumped)

Linux lax.lindev.ch [2] 3.13.11-nrjQL-desktop-1omv #1 SMP PREEMPT Sat Apr 26 01:07:23 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

Looks like no-force-clobber not working
Need a C-hero to check what's going on

There's some very very bad code at work...

They allocate a 1024 character buffer and then blindly assume that it can hold all gettext long options supported by wget prefixed with no-.

Adding force-clobber (while the patch itself is totally fine) on top of 1.15 (which added a few new options by itself) pushed it across the limit, overrunning the buffer.

Fix committed, but we need to get an older wget into the build roots so the new one can be built... I'm copying in the version from 2014.0, rebuilding metadata and then building fixed wget.

ttyl
bero

Reply via email to