Milan Jurik writes:
> Maybe it should be prohibited to push unrelated CRs in one changeset
> (and RTI)? It will help with many things, e.g. regression hunting and
> backports. It isn't so huge problem with Mercurial to move changesets
> between workspaces if you are working on several CRs in parallel. Today
> we have some huge-list-CRs changesets in one subsystem which have no
> reason to go together.

"Prohibit" seems extreme to me.  There are sometimes good reasons
(such as test considerations and things that are fixed as side-effects
of some larger restructuring) to put multiple apparently-unrelated CRs
into one changeset.  Forcing a breakup will force submitters to run
expensive (and redundant) tests on each CR individually, and in some
cases (such as restructuring) may not actually be possible at all.

It seems good to encourage people mixing apples and oranges not to do
so, but it also doesn't seem to me that's actually a problem in ON.
(Can you cite cases where we really do have huge changesets that have
absolutely *no* reason at all to go together?)

Instead, I think people are just going through the pain of getting
used to a new source code management system.  It isn't SCCS, and it
works differently.  We're going to have to get used to the fact that
the new system doesn't normally give you per-file comments, so (more
than ever) you do have to look at the CRs to understand the bits.  And
that means (more than ever) making sure that CRs are updated properly.

In fact, for backports, I think this is actually a healthy change.  It
used to be easier to cherry-pick a single SCCS delta for a single CR
(out of one of those big Teamware putbacks that have always been
common) to backport to a previous release.  However, as the fix for
that one CR likely had never actually been tested in isolation, and
the whole wad was soaked in the marketing release as one unit, the
idea of doing that individual backport was a bit sketchy, and possibly
even just plain wrong.

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

Reply via email to