John Sonnenschein wrote:
> I've tried the normal channel with no bites, seems people don't like
> doing CR ;)
>
> Anyhow, could I get a code review/sanity check on 6733971 from someone ?
>
> code at:
> http://cr.opensolaris.org/~error404/6733971/
BTW: The patch was done using the attached script
("buildcr6733971fix.sh") (and manual cleanup from John's side to make
"pbchk" happy), e.g. the patch was done via an automated way which
simply does three things:
1. Add a space between "(" and "$(LHEAD)" to avoid that it looks like
"((" for POSIX shells.
2. Add a space between "$(LTAIL)" and ")" to avoid that it looks like
"))" for POSIX shells.
3. Update CDDL
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildcr6733971fix.sh
Type: application/x-sh
Size: 3888 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/on-discuss/attachments/20081223/d2387580/attachment.sh>