Hi,

I'm looking to get a review on this bug that affects pkgmk and the ON
builds. I went through analyzing it and trying to fix it two years ago
and tried to pawn it off and failed. So, here's my try now that the
SVR4 package commands are in ON.  I have one internal reviewer already
in case nobody bites.

 http://cr.opensolaris.org/~pwernau/fix-6476447.onnv/

 6476447 pkgmk warns about the wrong i. script

I've updated the public comments of the bug to summarize the issue.

One can test this fix by replacing pkgmk and running "make pkg" in
usr/src/pkgdefs/SUNWcsd (where the bug was originally found), or by
running pkgmk on any pkg, ON or otherwise, that has multiple class
action scripts.

I've specifically put in #ifdef'd VERBOSE comments for anyone else who
needs to try to fix this later. The whole concept of validating control
scripts is a bit tenuous anyway, but it is a long time feature of SVR4
packaging and part of the documentation and output.

This has been tested the best I can come up with and the fixes are based
on problems seen while parsing actual scripts in the ON consolidation.

Thanks,
Paul

Reply via email to