I was told to do hg nits, how is that different then hg pbchk ?
James Carlson wrote: > Cyril Plisko writes: > >> I was under impression that as a part of full nightly run there is >> cstyle cleanness check being run as well. However, yesterday I noticed >> that while one of my files wasn't cstyle clean the nightly mail msg >> says: >> > [...] > >> So, was I under false impression ? >> > > Yes. That section actually shows the output of "dmake check" in the > $SRC directory. Lower-level makefiles that have some provision for > the "check" target will then perform whatever checks are coded for. > > In general, there are checks for files delivered as source (headers > and manifests), but not otherwise. > > >> Is there any automatic mean to help >> keep sources cstyled ? (I mean other than human running cstyle >> manually). >> > > The current means is to demand that users do "hg pbchk" before putting > back, and to ask them (as part of the RTI process) whether they've > done so. The gatekeepers also have scripts that check each putback -- > including doing incremental builds and other checks -- and will send > "is this you?" messages to apparent offenders. > > It's not perfect, but running cstyle on all of the code during every > nightly run would be really wasteful and would false on a huge number > of files. (There's a lot of third-party code that's not clean and > never will be.) > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/on-discuss/attachments/20081022/b2ea9b78/attachment.html>
