Vladimir Kotal wrote: > James Carlson wrote: >> Vladimir Kotal wrote: >>> Hi all, >>> >>> I'd like to get some reviewers for the addition of daemon() to libc. >>> >>> More details: >>> http://arc.opensolaris.org/caselog/PSARC/2009/444/ >>> >>> webrev is here: >>> http://cr.opensolaris.org/~vkotal/daemon_libc-4471189.onnv/ >> >> usr/src/cmd/ssh/include/config.h >> >> - why not #define HAVE_DAEMON? > > I had it there initially (after the removal of daemon.[ch] from ssh > sources) but Jan P. made me to remove it since it has no meaning now. So > Nico has the same opinion as the I-team :)
OK, fair enough. >> usr/src/lib/libc/port/gen/daemon.c >> >> 54,66: nit: could have used EXIT_SUCCESS. > > Fixed. I will post updated webrev once I am done with other reviewers' > comments. Sounds good. No other comments. -- James Carlson 42.703N 71.076W <carlsonj at workingcode.com>
