Ah, didn’t know about that one. This is great, indeed useful, as long as we have a set of active committers. In the future, we might come across project with a list a committers, but only one is active, hence this process would block merging any code. Such scenarios occurred/are occurring in ODL, and if memory serves well, TSC is addressing them in case by case basis. Food for thoughts... but worth being consider earlier in the process.
> On May 15, 2017, at 10:43 AM, ROSE, DANIEL V <[email protected]> wrote: > > Nacr is a check in gerrit that forbids the person who submitted a change from > also approving it for addition into the code base. This means if I am a > committer and I submit a change to gerrit, I can not +2 my own work, some > other committer has to come and code review me and then +2. > > > Thanks, > > Daniel Rose > ECOMP / ONAP > com.att.ecomp > 732-420-7308 > > > -----Original Message----- > From: Alexis de Talhouët [mailto:[email protected]] > Sent: Monday, May 15, 2017 10:41 AM > To: ROSE, DANIEL V <[email protected]> > Cc: [email protected] > Subject: Re: [onap-discuss] [dev] Missing issue-id in commit message > > What do you mean by non-author code reviews? allowing it or forbidding it. If > the later, I would disagree as I think in open source, anyone should be able > to review code, and provide comments on changes. > > Regarding jira issues, I tend to think it is a good practice to have a jira > ticket tracking the work being done, hence as far as I’m concerned, I’m all > in favour to that. But anyway, I think this is a TSC decision (to enforce it). > > Thanks, > Alexis > >> On May 15, 2017, at 10:21 AM, ROSE, DANIEL V <[email protected]> wrote: >> >> I also had a proposal for non-author code reviews being enforced and that is >> delayed too. >> >> So as we form new projects we can make a decision about if nacr and jira >> issues are something we want (either per project or overall). >> >> >> Thanks, >> Daniel Rose >> ECOMP / ONAP >> com.att.ecomp >> 732-420-7308 >> >> >> -----Original Message----- >> From: Alexis de Talhouët [mailto:[email protected]] >> Sent: Monday, May 15, 2017 10:01 AM >> To: ROSE, DANIEL V <[email protected]> >> Cc: [email protected] >> Subject: Re: [onap-discuss] [dev] Missing issue-id in commit message >> >> Ok. Good to know it’s expected then. I’ll address that in my commits. >> >> Thanks, >> Alexis >>> On May 15, 2017, at 9:33 AM, ROSE, DANIEL V <[email protected]> wrote: >>> >>> Right now it is not required, but we had set a timeline to make it >>> required. Not sure where that went. Either way I would say its strongly >>> encouraged to have a jira ticket for your submits so that others can have >>> some context for your issues. >>> >>> >>> >>> Thanks, >>> Daniel Rose >>> ECOMP / ONAP >>> com.att.ecomp >>> 732-420-7308 >>> >>> -----Original Message----- >>> From: [email protected] >>> [mailto:[email protected]] On Behalf Of Alexis de Talhouët >>> Sent: Monday, May 15, 2017 8:53 AM >>> To: [email protected] >>> Subject: [onap-discuss] [dev] Missing issue-id in commit message >>> >>> Hi, >>> >>> I’m seeing this warning when submitting patches to ONAP gerrit: >>> >>> remote: Missing issue-id in commit message >>> remote: Commit 44775a0ec9732f2874c1b07fee15c393949b55b8 not associated to >>> any issue >>> remote: >>> remote: Hint: insert one or more issue-id anywhere in the commit message. >>> remote: Issue-ids are strings matching ([A-Z][A-Z0-9]{1,9}-\d+) >>> remote: and are pointing to existing tickets on its-jira Issue-Tracker >>> >>> Is having a issue-if required? >>> As my commit successfully go through, I believe it is not mandatory, but >>> I’m wondering if this warning could be removed? >>> >>> Thanks, >>> Alexis >>> _______________________________________________ >>> onap-discuss mailing list >>> [email protected] >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.onap.org_mailman_listinfo_onap-2Ddiscuss&d=DwIGaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=2wwdGZ3YcpSivQ2Kio028A&m=n6qtQ2m5CO7Ja6kNT67Kj0782QkrVFVQp5GBmZX30Ho&s=ijbYsl1A2QuaiHmHoIoZhz0nl-_jLRo1gGRduzr__9Y&e= >>> >> > _______________________________________________ onap-discuss mailing list [email protected] https://lists.onap.org/mailman/listinfo/onap-discuss
