To my knowledge, Gerrit doesn’t automatically add reviewers to changes on 
submission.  However, if you add a comment/reply to a change, then it 
automatically adds you as a reviewer to that change, and will notify you of any 
future amendments thereof.

Thanks,
Gary

From: DRAGOSH, PAMELA L (PAM) [mailto:pdrag...@research.att.com]
Sent: Thursday, August 10, 2017 10:31 AM
To: Gary Wu <gary.i...@huawei.com>; eric.deb...@orange.com; 
onap-...@lists.onap.org; onap-discuss@lists.onap.org
Cc: RICHOMME Morgan IMT/OLN <morgan.richo...@orange.com>
Subject: Re: [onap-discuss] [onap-tsc] Code Review: how to avoid long delay to 
review

My understanding was that when someone submits code for review, that committers 
automatically get email notification for it and also automatically get added to 
the list of reviewers. However, this has been inconsistent.

Being a committer, I have noticed that sometimes I am added as a reviewer 
automatically, while other times I am not. Not sure why not. I do utilize the 
“watch” projects functionality so that I don’t miss something because of this 
inconsistency.

Can someone from LF clarify the consistency? Or is my understanding incorrect?

Thanks,

Pam


From: 
<onap-discuss-boun...@lists.onap.org<mailto:onap-discuss-boun...@lists.onap.org>>
 on behalf of Gary Wu <gary.i...@huawei.com<mailto:gary.i...@huawei.com>>
Date: Thursday, August 10, 2017 at 1:20 PM
To: "eric.deb...@orange.com<mailto:eric.deb...@orange.com>" 
<eric.deb...@orange.com<mailto:eric.deb...@orange.com>>, 
"onap-...@lists.onap.org<mailto:onap-...@lists.onap.org>" 
<onap-...@lists.onap.org<mailto:onap-...@lists.onap.org>>, 
"onap-discuss@lists.onap.org<mailto:onap-discuss@lists.onap.org>" 
<onap-discuss@lists.onap.org<mailto:onap-discuss@lists.onap.org>>
Cc: RICHOMME Morgan IMT/OLN 
<morgan.richo...@orange.com<mailto:morgan.richo...@orange.com>>
Subject: Re: [onap-discuss] [onap-tsc] Code Review: how to avoid long delay to 
review

On notifications:  Gerrit has built-in support to send email notifications on 
code changes.  There are two methods:


1.       The contributor can explicitly add a list of reviewers to the proposed 
change, which will trigger a notification to those individuals.  This should 
ideally be done after all expected amendments to the change are completed, and 
after Jenkins has verified the change.

2.       Anyone can subscribe to be notified of changes in any particular repo, 
via the “Watched Projects” section in their profile settings.

I would recommend that all committers subscribe to watch changes to the 
projects for which they are committers for.

Thanks,
Gary

From: onap-tsc-boun...@lists.onap.org<mailto:onap-tsc-boun...@lists.onap.org> 
[mailto:onap-tsc-boun...@lists.onap.org] On Behalf Of 
eric.deb...@orange.com<mailto:eric.deb...@orange.com>
Sent: Thursday, August 10, 2017 6:30 AM
To: onap-...@lists.onap.org<mailto:onap-...@lists.onap.org>
Cc: RICHOMME Morgan IMT/OLN 
<morgan.richo...@orange.com<mailto:morgan.richo...@orange.com>>
Subject: [onap-tsc] Code Review: how to avoid long delay to review

Hello

There was a code review pending since 5 days due to a lack of reviewers. I 
think we should adopt some best practices to avoid such delay.
A committer should inform the PTL and a list of reviewers by mail (typically 
the project committers and other people involved in the project)


OPNFV is listing all the committers (they can provide a +2 code review) in a 
dedicated file INFO for each repo:

https://git.opnfv.org/functest/tree/INFO<https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opnfv.org_functest_tree_INFO&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=jwTiArcEj6aUX0HjV0M3dT12gUtk7rC07xpgpVZkS_4&m=kfG7J7QFRskPFQHbiYUYr6g6UoeCi2TfB8rCxUddBk4&s=nvGE-5pAM4Pjv3ywr9WX5NG1acXOw2qhsK0R8HZ522U&e=>

https://git.opnfv.org/promise/tree/INFO<https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opnfv.org_promise_tree_INFO&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=jwTiArcEj6aUX0HjV0M3dT12gUtk7rC07xpgpVZkS_4&m=kfG7J7QFRskPFQHbiYUYr6g6UoeCi2TfB8rCxUddBk4&s=dFDmEqQS6wK4HmBT3XckZ6yMTvsxiwZhctiJ8MoTcDM&e=>



OPNFV also defined some rules for committers promotions and removal that should 
inspire us.

https://wiki.opnfv.org/display/DEV/Committer+Promotions<https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.opnfv.org_display_DEV_Committer-2BPromotions&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=jwTiArcEj6aUX0HjV0M3dT12gUtk7rC07xpgpVZkS_4&m=kfG7J7QFRskPFQHbiYUYr6g6UoeCi2TfB8rCxUddBk4&s=SJsj6dKhWtwN8BwHXB72gJIUDcCKfaquzs91GU0Ivro&e=>

https://wiki.opnfv.org/display/DEV/Committer+Removal<https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.opnfv.org_display_DEV_Committer-2BRemoval&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=jwTiArcEj6aUX0HjV0M3dT12gUtk7rC07xpgpVZkS_4&m=kfG7J7QFRskPFQHbiYUYr6g6UoeCi2TfB8rCxUddBk4&s=PSFlevB1_yWaC51g51pGXyZJ0_cNZPgndz-SDJAaSiA&e=>

Thanks @Morgan (OPNFV Ambassador & TSC Member) for the links

Regards

Eric

_________________________________________________________________________________________________________________________



Ce message et ses pieces jointes peuvent contenir des informations 
confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce 
message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages 
electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou 
falsifie. Merci.



This message and its attachments may contain confidential or privileged 
information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete 
this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been 
modified, changed or falsified.

Thank you.
_______________________________________________
onap-discuss mailing list
onap-discuss@lists.onap.org
https://lists.onap.org/mailman/listinfo/onap-discuss

Reply via email to