I’ve submitted a change to portal that enables sonar code coverage with oparent. Please review:
https://gerrit.onap.org/r/#/c/16899/ Thanks, Gary From: TALASILA, MANOOP (MANOOP) [mailto:talas...@research.att.com] Sent: Monday, October 02, 2017 8:38 AM To: KOTTA, SHIREESHA (SHIREESHA) <sk4...@research.att.com<mailto:sk4...@research.att.com>>; Gary Wu <gary.i...@huawei.com<mailto:gary.i...@huawei.com>>; LOTT, CHRISTOPHER M (CHRISTOPHER) <cl...@research.att.com<mailto:cl...@research.att.com>> Subject: Re: ONAP Parent breaks Portal Sonar?? Hi Gary, The portal repo could not generate SONAR report while having oparent. So, we had to comment it now to address the SONAR issue as priority by EOD today. However, we need a long-term fix to put the oparent back in our root pom. Please advise, if you can suggest any changes, so that both the oparent and SONAR can work fine. To recreate the issue, you can just clone “portal” repo and run “mvn clean install sonar:sonar”, if you have sonar server installed locally, you will see the code coverage percentage. Once you add the oparent back, then by repeating the sonar scan, it is not reporting the code coverage. Manoop From: "TALASILA, MANOOP (MANOOP)" <talas...@research.att.com<mailto:talas...@research.att.com>> Date: Monday, October 2, 2017 at 8:50 AM To: "KOTTA, SHIREESHA (SHIREESHA)" <sk4...@research.att.com<mailto:sk4...@research.att.com>>, Gary Wu <gary.i...@huawei.com<mailto:gary.i...@huawei.com>>, "LOTT, CHRISTOPHER M (CHRISTOPHER)" <cl...@research.att.com<mailto:cl...@research.att.com>> Subject: Re: ONAP Parent breaks Portal Sonar?? Yes, adding oparent is not generating jacoco report in sonar. So I had to remove it. The current portal repo is now generating sonar report at least locally now. I am still struggling with LF support to understand why the same report is not seen in sonar even when the job succeeded. Manoop On Mon, Oct 2, 2017 at 8:26 AM -0400, "LOTT, CHRISTOPHER M (CHRISTOPHER)" <cl...@research.att.com<mailto:cl...@research.att.com>> wrote: Good morning I see in commits over the weekend that Manoop removed "OParent" from the Portal master POM while working on Sonar. Did the use of OParent break Sonar? If so I hope you will please provide details to Gary Wu immediately. None of us want to have a sudden last-minute release action only because Portal is not compliant with LF release guidelines such as use of OParent. Thanks.
_______________________________________________ onap-discuss mailing list onap-discuss@lists.onap.org https://lists.onap.org/mailman/listinfo/onap-discuss
