We were trying to implement it quite few time ago, but it conflicted with the peak of the time in which the devs were doing their changes before the code freeze at a very rapid flow.
I synced with Gildas and he suggested we move this improvement to Nov 16 and for now to start educating the devs about this restriction by adding comments in their gerrit changes. I agree with Gildas that this enforcement could have caused quite a bit of frustration to developers during this time, but this could be welcomed after Nov 16. On Mon Oct 23 11:07:04 2017, [email protected] wrote: > I thought that this in fact had already been implemented (the > capitalization-sensitive check for "Issue-ID"). > > Thanks, > Gary > > -----Original Message----- > From: Kenny Paul via RT [mailto:[email protected]] > Sent: Sunday, October 22, 2017 7:51 PM > To: Gary Wu <[email protected]> > Cc: [email protected] > Subject: [ONAP Helpdesk #45257] [integration] Issue-ID check > > Gary, looking for conformation that this is in fact something that you > want to put on hold until after the release. > > Thanks! > -kenny > > > > On Thu Oct 12 15:53:22 2017, jwagantall wrote: > > Dear Team, > > > > just a small update on this. After discussing with Gildas, we thought > > that this enforcement will create a little bit of obstacles for > > developers since we are so close to our release goals. > > > > We are planning to merge this change after Nov 16 when we have more > > flexibility. > > > > Thanks! > > Jess > > > > On Thu Sep 21 16:21:38 2017, agrimberg wrote: > > > On Sat Sep 02 11:19:32 2017, [email protected] wrote: > > > > Gary, > > > > Good point, the pre-commit script is cAP agnostic but the > > > > links > > > > are not. > > > > I have also noticed that periodically some jiras will not > > > > show > > > > their gerrit reviews - even though they were previously linked. > > > > The linking between confluence and jira is also currently > > > > broken in the jira-to-confluence direction but not the reverse > > > > since April. > > > > > > Greetings folks, > > > > > > If you see that JIRA is not showing you any changes that you know > > > exist try doing the following when looking at the JIRA issue: > > > > > > --[cut]-- > > > Select the down arrow next to the Gerrit Reviews Make sure that > > > 'Show All Reviews' is selected If it is, switch it to 'Show Open > > > Reviews' and then back > > > --[cut]-- > > > > > > What happens is that sometimes the Gerrit plugin disconnects from > > > the Gerrit server and toggling those settings generally forces it > > > to > > > reconnect and refresh any caches that it has. > > > > > > > Sent this to the group on the 18th > > > > Watch your commit message case for JIRA links - the "Issue-ID" > > > > is > > > > case sensitive > > > > Only a "Issue-ID:" prefix will link gerrit reviews to jira - > > > > cases like "issue-id, Issue-Id" will fail to link until the LF > > > > makes their pre-commit check case-insensitive > > > > > > > > https://wiki.onap.org/display/DW/Commit+Messages#CommitMessages- > > > > CommitStructure > > > > > > I now have a change in for review, which will require a Gerrit > > > restart to take effect when it's rolled out, which will enforce the > > > following regex for the JIRA check: > > > > > > ^Issue-ID: ([A-Z][A-Z0-9]{1-9}-\d+) > > > > > > This means that it will _enforce_ that JIRA issues start with > > > 'Issue- > > > ID: ', yes a _single_ space will be required. NOTE: we tell folks > > > that this needs to be in the footer, but technically it can be > > > anywhere and pass as we have no ability to the check to only > > > operate > > > on the footer, but honestly, it looks tacky if it isn't properly in > > > the footer ;) > > > > > > When this change rolls out, another comment linking change will > > > also > > > roll out which will enable Gerrit change IDs to be relinked back > > > into Gerrit meaning that people will be able to leave notes in the > > > comments such as: > > > > > > --[cut]-- > > > This change requires I4937bfdbecc4aec2363497aba12b9c0389cf2c90 > > > from > > > repo foo to work correctly. > > > --[cut]-- > > > > > > And the I4937bfdbecc4aec2363497aba12b9c0389cf2c90 would be properly > > > linked to the other change. This makes those sorts of comments more > > > bullet proof to change should we have to do rebuilds of the Gerrit > > > system or migrate repositories to a different one in the future > > > where the short change number would end up changing. > > > > > > -Andy- > > > _______________________________________________ onap-discuss mailing list [email protected] https://lists.onap.org/mailman/listinfo/onap-discuss
