Jessica, Gildas, Is there anything we are missing - I don't see the normal "submit" button because the non-author commit check is blocking it /michael
Yes, looks like an issue - the "non-author code review" should have been populated when one of us did a +2 - I even hit the verify (can't actually verify the partial seed code until we get a runnable skeleton and docker builds going) - didn't populate the field Asking the LF. /michael From: Luke Parker Sent: Monday, July 16, 2018 11:48 PM To: Prudence Au <[email protected]>; Michael O'Brien <[email protected]>; Luke Parker <[email protected]>; Avdhut Kholkar <[email protected]>; [email protected] Subject: Re: [logging-analytics] POMBA Merge request +2d, but I don't get the option to merge. The gerrit configuration is a little different to ours, so I can't remember exactly what it normally offers, and this is the only review currently pending, so I can't cross-check. Anybody else? Thanks, Luke On 17/07/18 04:20, Prudence Au wrote: Hi logging-analytics committers, For tomorrow's meeting, I would like to bring to your attention for the following code review. This is the pojo repo needed for other POMBA components. The POMBA team would like to have it merged so that we can continue on with other work. https://gerrit.onap.org/r/#/c/56223/7 Thanks in advance. Cheers, Prudence Prudence Au Software Development Manager Data Experience 251455038 (office - internal) 613-595-5038 (office - external) 613-327-7646 (mobile) [amdocs-a] Read the latest on Amdocs.com<http://www.amdocs.com/><http://www.amdocs.com/> and the Amdocs blog network<http://blogs.amdocs.com/><http://blogs.amdocs.com/> - and follow us on Facebook<http://www.facebook.com/Amdocs><http://www.facebook.com/Amdocs>, Twitter<http://twitter.com/Amdocs><http://twitter.com/Amdocs>, LinkedIn<http://www.linkedin.com/company/amdocs><http://www.linkedin.com/company/amdocs> and YouTube<http://www.youtube.com/amdocs><http://www.youtube.com/amdocs>. This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement, you may review at https://www.amdocs.com/about/email-disclaimer <https://www.amdocs.com/about/email-disclaimer> -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11177): https://lists.onap.org/g/onap-discuss/message/11177 Mute This Topic: https://lists.onap.org/mt/23542020/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
