I’d like to put some context on this one. The merge in question was pushed to the container_test branch for well over a month for review prior to the merge. It was not just a 20 minute review. We have had extensive walk throughs of the large push on the SO weekly meetings. I think this Friday will be the third set of such walk throughs. I do agree that if possible we should have broken it up. We could not find a sane way to do that, and I apologize for that. We did attempt to review and work with the community knowing that such a large push was coming. I do not foresee these types of pushes continuing going forward.
Thanks -Steve From: <[email protected]> on behalf of "OBRIEN, FRANK MICHAEL" <[email protected]> Reply-To: "[email protected]" <[email protected]>, "OBRIEN, FRANK MICHAEL" <[email protected]> Date: Wednesday, August 1, 2018 at 9:16 PM To: "[email protected]" <[email protected]>, onap-tsc <[email protected]> Subject: [onap-discuss] seed code: 6100 file merge reviewed at 150 files/min Team, Don’t like being the “onap first” good/bad cop but a review just went in with 6100 files (half are deletions) - so 3000 files reviewed (including ssh.exe.stackdump) in 20 min looks like seed code developed offline to me. There are other projects that are also bringing in work that was done “offline” from ONAP – but In most of these cases the time is taken to break up the commits into microservice pieces and bring the system into onap organically via their particular dependency hierarchy (root containers first). I find it odd that the we allow such huge pushes of seed code with a duration of 20 min in our 3rd release – it disadvantages those teams that work directly in ONAP or try to incrementally add seed code (it takes time to break up/merge a lot of code). /michael This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement, you may review at https://www.amdocs.com/about/email-disclaimer<https://urldefense.proofpoint.com/v2/url?u=https-3A__www.amdocs.com_about_email-2Ddisclaimer&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=shs6nPzThSiGJml9VXN0Eg&m=AMdGIpY8JMj4I0Yn24G2hOSLOWgN5-_dBwfK3E4vUMs&s=X7B2m6EKmv0UhwS5TMiGt6z4UX8YjX5vSxwsWutU9R8&e=> -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11609): https://lists.onap.org/g/onap-discuss/message/11609 Mute This Topic: https://lists.onap.org/mt/24092446/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
