Hi All, In the ONAP Policy Framework , we have guidelines for committing code reviews that works rather well. We expect that other projects have very similar if not identical guidelines for code reviews. However, our guidelines are not fully documented.
The ONAP best practice for code reviews appear on this page created by Gildas: https://wiki.onap.org/display/DW/Code+Review I have created a draft sub page off Gildas' page and added the guidelines used in the PF project to Gildas' list: https://wiki.onap.org/display/DW/Draft+Guidelines+for+Committing+Code+Reviews I would like to look for input and contributions from other projects and interested people so that we can come to an ONAP-wide consensus on code review commits. Please amend/comment/add to/delete from the page above. Once we have an acceptable degree of consensus the guidelines can then be brought to the PTL meeting and then the TSC for approval and be ready for the heavy lifting in Dublin. What is suggested is probably what everyone is already doing but it's better to write them down. Best Regards Liam -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14231): https://lists.onap.org/g/onap-discuss/message/14231 Mute This Topic: https://lists.onap.org/mt/28573706/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
