The DMaaP team has posted results – looks good – I have +1’d the review along with several other developers – we can get an OOM committer to merge +2 the change as soon as the -1 review is removed from March 1st.
Workaround for -1 hanging reviews: There is a workaround to remove -1 reviews where the reviewer may be away or on vacation – submit a new patch to the review – in this case do a minor change to a comment on a helm chart that will not require a full CD retest/review and then we will reset the reviews – we can then +2 the change The procedure to repatch (rebase is not enough) is here if you need it - https://wiki.onap.org/display/DW/ONAP+Development#ONAPDevelopment-Amendingexistinggerritchangesinreview /michael From: [email protected] <[email protected]> On Behalf Of Michael O'Brien Sent: Thursday, March 21, 2019 3:30 PM To: Conor Ward <[email protected]> Cc: Yang Xu (Yang, Fixed Network) <[email protected]>; Borislav Glozman <[email protected]>; Ronan Keogh <[email protected]>; Emmett Cox <[email protected]>; Gerard Nugent <[email protected]>; Fiachra Corcoran <[email protected]>; de Talhouet, Alexis <[email protected]>; Mariusz Sobucki <[email protected]>; Paul Dennehy P <[email protected]>; Tom O'Neill <[email protected]>; Mike Elliott <[email protected]>; Prudence Au <[email protected]>; James MacNider <[email protected]>; Catherine LEFEVRE <[email protected]>; Brian <[email protected]>; [email protected]; [email protected] Subject: Re: [onap-discuss] DMaaP Certificate issue for 3.0.2-ONAP tag Conor, Adding onap-discuss as we need to keep the other members of TSC-119/120 in the loop for Monday https://jira.onap.org/browse/TSC-119 https://jira.onap.org/browse/TSC-120 No problem, the deadline is Monday – I would need the -1 review from [email protected]<mailto:[email protected]> addressed or removed – that was March 8th Ronan, conor, can you repost the hc and pod results as well as getting Michal to retest with the patch you posted since his last review The last checks I see are from the 1st before the -1 https://gerrit.onap.org/r/#/c/79210/ /michael Code-Review -1 Michal Ptacek From: Conor Ward <[email protected]<mailto:[email protected]>> Date: Thursday, March 21, 2019 at 12:25 To: Michael O'Brien <[email protected]<mailto:[email protected]>> Cc: "Yang Xu (Yang, Fixed Network)" <[email protected]<mailto:[email protected]>>, Borislav Glozman <[email protected]<mailto:[email protected]>>, Ronan Keogh <[email protected]<mailto:[email protected]>>, Emmett Cox <[email protected]<mailto:[email protected]>>, Gerard Nugent <[email protected]<mailto:[email protected]>>, Fiachra Corcoran <[email protected]<mailto:[email protected]>>, Mariusz Sobucki <[email protected]<mailto:[email protected]>>, Paul Dennehy P <[email protected]<mailto:[email protected]>>, Tom O'Neill <[email protected]<mailto:[email protected]>> Subject: DMaaP Certificate issue for 3.0.2-ONAP tag Hi Michael, Is it possible to get this code change<https://gerrit.onap.org/r/#/c/79210/> merged before 25th March as the 3.0.2-ONAP tag is being created then. If we need to do anything else to get this merged let us know as we have already posted the running pods and robot healthcheck results for DMaaP components. Kind Regards, Conor This email and the information contained herein is proprietary and confidential and subject to the Amdocs Email Terms of Service, which you may review at https://www.amdocs.com/about/email-terms-of-service This email and the information contained herein is proprietary and confidential and subject to the Amdocs Email Terms of Service, which you may review at https://www.amdocs.com/about/email-terms-of-service <https://www.amdocs.com/about/email-terms-of-service> -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16279): https://lists.onap.org/g/onap-discuss/message/16279 Mute This Topic: https://lists.onap.org/mt/30699859/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
