I will review and give feedback. At a quick glance i see hard coded values like bbs and duplication of existing keywords that will be confusing Get Customer
I think this is solvable but we do to look for opportunities to reuse and avoid confusion. I also think we might want to name scripts as csit_ or something to help clarify. Finally the bbs robot seems use case specific instead of a reusable regression but i haven't look closely since i am traveling. Btian Sent via the Samsung Galaxy S8, an AT&T 5G Evolution capable smartphone -------- Original message -------- From: Keong Lim <[email protected]> Date: 4/4/19 6:07 PM (GMT-08:00) To: "FORSYTH, JAMES" <[email protected]>, "ROSE, DANIEL V" <[email protected]>, "LEFEVRE, CATHERINE" <[email protected]>, [email protected], "FREEMAN, BRIAN D" <[email protected]> Cc: [email protected] Subject: what is the architectural direction for ONAP testsuite repository? Hi Jimmy, Daniel, Catherine, Stephen, Brian, Based on Catherine's presentation at https://wiki.onap.org/display/DW/PTL+2019-02-19<https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.onap.org_display_DW_PTL-2B2019-2D02-2D19&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=e3d1ehx3DI5AoMgDmi2Fzw&m=hqekfMCQERY3sY5kHTfuYXt0O9j4HeVsgF1UGMj2SnI&s=-GeSaToqFQf2smsQtsDrAeJc_KYL63Mi8bel-gYJplg&e=> the AAI team has started to add more robot testcases into the testsuites repository for CSIT-style regression testing of each releases' use cases. See also https://jira.onap.org/browse/AAI-2184<https://urldefense.proofpoint.com/v2/url?u=https-3A__jira.onap.org_browse_AAI-2D2184&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=e3d1ehx3DI5AoMgDmi2Fzw&m=hqekfMCQERY3sY5kHTfuYXt0O9j4HeVsgF1UGMj2SnI&s=zOv8SeeGXVP7Td6piF6SuesUMFq99YRz6hSnCYeGeJs&e=> and https://jira.onap.org/browse/AAI-2208<https://urldefense.proofpoint.com/v2/url?u=https-3A__jira.onap.org_browse_AAI-2D2208&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=e3d1ehx3DI5AoMgDmi2Fzw&m=hqekfMCQERY3sY5kHTfuYXt0O9j4HeVsgF1UGMj2SnI&s=cdPyX7r4_jZy9Mz2lrkdmLJHYdNI3YPrZ0VK4-GZmp4&e=> For AAI, that means wanting to: - detect the presence/absence of schema elements and EdgeRule relationships as they change from version (n) to (n+1) - confirming that these changes stay functional for subsequent releases - being able to manipulate individual objects/sub-objects and relationships in a flexible and general-purpose manner - (eventually) achieve 100% coverage of schema elements and relationships - (perhaps) testing performance of AAI services across the board (some problem use cases have been identified in https://wiki.onap.org/display/DW/2019-04-04+AAI+Developers+Meeting<https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.onap.org_display_DW_2019-2D04-2D04-2BAAI-2BDevelopers-2BMeeting&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=e3d1ehx3DI5AoMgDmi2Fzw&m=hqekfMCQERY3sY5kHTfuYXt0O9j4HeVsgF1UGMj2SnI&s=fiF504yamC7ihcPIC5MOjFRwAO5k8mN4_yqmbVhOprM&e=> ) The current templates and robot keywords in testsuite repository seems to be focussed on the demo scenario and healthchecks, to the point of having many hard-coded values, sub-objects and relationships, as well as being stuck on API v11 schema and minimal coverage of the bare necessities. In the first gerrit review https://gerrit.onap.org/r/#/c/79583/<https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.onap.org_r_-23_c_79583_&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=e3d1ehx3DI5AoMgDmi2Fzw&m=hqekfMCQERY3sY5kHTfuYXt0O9j4HeVsgF1UGMj2SnI&s=vvn7yC1j_JRbrKKDHVvYYO5vT9GoqTPIpEJV1wY1Ztk&e=> there was a bit of discussion as to whether the testsuites repository is the right place to put such things. The feeling was that the tests are only run on the latest release and don’t need to test for regressions. But eventually it was accepted and merged. In the most recent gerrit review https://gerrit.onap.org/r/#/c/84195/<https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.onap.org_r_-23_c_84195_&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=e3d1ehx3DI5AoMgDmi2Fzw&m=hqekfMCQERY3sY5kHTfuYXt0O9j4HeVsgF1UGMj2SnI&s=POCDv_Gnrp1hgBay3G1C3lB_358FNkHnJTNkygzA9PM&e=> we get a -2 on working code (that also doesn’t break existing code) because it didn’t reuse hard-coded demo testcases. We don’t want to change the demo, but I think the demo code should be refactored so that demo-specific parts are separate from general-purpose reusable common base code. For refactoring to happen, we still need more foundations that allow for manipulating sub-objects and relationship-lists individually, as well as being able to compose the relationships between schema elements in the same way they are modelled in the AAI services. We need to avoid the problems inherent in number of REST URL combinations as enumerated in the swagger-generated API documents, while still being able to test every part of the schema. There are still more steps to be taken. We are still just setting the stage. There are no backwards steps in these commits. We want to be a help rather than a hindrance to the ONAP projects. We do not want to be swimming against the current. Right now, feels like there’s a fraction too much friction… So the questions are: - what is the architectural direction for testsuite repository? - Is the testsuites/aai sub-directory a place that the AAI team can use as required? - Should these AAI-specific CSIT-style robot testcases go into an AAI repository instead of the testsuite repository? - Do other ONAP projects need/want to share in the robot scripts that AAI team is writing? Thanks, Keong -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16479): https://lists.onap.org/g/onap-discuss/message/16479 Mute This Topic: https://lists.onap.org/mt/30919602/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
