Hi I would like to share some personnal views on community practices. I do not pretend that they are all applicable or even the best ones. Moreover they may differ from one project to another depending on the code activity, the number of committers and contributors.
Everything can be discussed however the following recommendations could be useful if we want to stabilize a Master rolling release (i.e. a Master branch always deployable). This would save integration time and allow to spend more time on use cases rather than systematically spending some weeks before the release to simply get something usable:) General Gerrit review ********************* - the same person MUST NOT submit a patch/+2/Merge - when possible, 2x +2 are required before merge (depends on the number of committers) - it is encouraged to have geographically distributed committers (Asia / Europe / North America) - if people submit an incomplete patchset (especially for correction), it is recommended to submit a new patchest on the existing patch rather that create a new patch and abandon the initial patch - abandoning a patch SHALL BE done by the patch owner, and if not possible by the committer OOM specific review ******************* - +2/Merge shall give a chance to the gating... It means that merge must not be done before the gating has been finalized (it usually takes 60-90 minutes). - Gating must be OK prior to merge on Master + onap-ci-windriver CI for release. With Dublin we may have the ambition to converge to a rolling release on master. With gating, we MAY detect any regression if any change breaks the gate. Healthcheck tests ***************** - each component shall provide at least 1 healthcheck robot test. At the moment we have ~ 240 pods and 32 helm charts [aaf, aai, appc, cassandra, clamp, cli, consul, contrib, dcae, dmaap, esr, log, mariadb, msb, multicloud, nbi, oof, policy, pomba, portal, robot, sdc, sdnc, so, uui, vfc, vid, vnfsdk, prometheus, weave scope] on one side and 61 healthcheck tests [aaf (2), aai, appc, clamp, cli, dcae (3), dmaap (3), log (3), modeling, msb, multicloud (8), nbi, oof (3), policy, pomba (9), sdc, sdnc, so, uui, vfc (15), vid, vnfsdk] When gating we check that the pods are Running (onap-k8s tests) then the healthcheck robot tests.. Healthcheck SHALL indicate that the component is running as expected (applicative verification). Project MUST maintain these tests and ensure their evolutions if needed (API evolution, HTTPS support, ...). Misc **** - more CSIT should be provided (it was asked by Catherine some weeks ago) and integrated in Gating - CIST MUST be to be executed on a k8s environemet (added to gating chain)! - components that are not involved directly on ONAP and not used by any use cases SHOULD be considered as addons and not be part of the release. Healthcheck SHOULD be run accordingly. It will lighten the solution and limit the surface of attack. Could be a topic for next DDF... Morgan _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17075): https://lists.onap.org/g/onap-discuss/message/17075 Mute This Topic: https://lists.onap.org/mt/31640082/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
