*There is a copy of email chain discussion:* -----------------------------------------------------
From: Rahul Sharma Sent: Thursday, December 5, 2019 1:41 PM To: SMOKOWSKI, STEVEN Nabil Gergis Cc: ZITELLA, MICHAEL V DORKING, KEITH Subject: Re: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI Thanks Steve. Yes, you are right - we can issue a POST on a sub object instead of a PUT on the base object. However, today we are doing a POST on the base object (Service) to create a sub object (generic-vnfs/vfModule), which doesn't look right to me. I propose we use "UpdateInstance" for Service, if we want to add another VNF under it, instead of CreateInstance for Service that we do today. Regards, Rahul From: SMOKOWSKI, STEVEN Sent: December 5, 2019 10:10 AM To: MNUSHKIN, DMITRY Nabil Gergis Cc: ZITELLA, MICHAEL V DORKING, KEITH Subject: Re: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI I don’t see an issue with them being a post, to a sub object, instead of a put on the base object. If that is the behavior you are describing Rahul. Can you write up what you are proposing to change? We can evaluate it for a future version. Thanks -Steve From: "MNUSHKIN, DMITRY" Date: Thursday, December 5, 2019 at 10:07 AM To: "Rahul Sharma" Cc: "ZITELLA, MICHAEL V" Subject: RE: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI ++ Mike and Keith From: Rahul Sharma [mailto:[email protected]] Sent: Wednesday, December 4, 2019 3:27 PM To: SMOKOWSKI, STEVEN Nabil Gergis Subject: Re: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI Hello Steve, No, what I am suggesting is adding vnf's, modules should be an update on the existing service-instance instead of a create. Regards, Rahul From: SMOKOWSKI, STEVEN Sent: December 4, 2019 3:33 PM To: Rahul Sharma Nabil Gergis Subject: Re: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI I am not following your issue clearly. Once a service is created, you can add vnf’s, modules forever. Are you saying it should be blocked at some point? Thanks -Steve From: "Rahul Sharma" Date: Wednesday, December 4, 2019 at 3:12 PM To: "MNUSHKIN, DMITRY" Cc: "SMOKOWSKI, STEVEN" Subject: Re: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI Thank you for prompt reply, Dmitry. When you say resume, does it mean the request was in a paused state before? Also, the current logic allows to continue creating VNFs under the same Service Instance - which in our opinion should be an update instead of a create since there is already a Service instance in AAI (which may have a vnf/vfmodule under it). We have a situation in our environment where a Service instance gets updated with new generic-vnfs (and vfmodule, vservers) when a user entered same service details again and again. Let us know what you think about it. Regards, Rahul From: MNUSHKIN, DMITRY Sent: December 4, 2019 2:16 PM To: BENJAMIN, MAX Nabil Gergis Cc: Rahul Sharma SMOKOWSKI, STEVEN Subject: RE: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI Hello Nabil, If you are sending request to create SI that has same (as previously executed request) service-instance-name, model-version-id, service-type and global-customer-id such request is considered “resume” if SI found in AAI matching all of the above fields. Exception will be thrown when SI name matches, but not other fields. Hope this helps, Thank you, Dmitry From: BENJAMIN, MAX Sent: Wednesday, December 4, 2019 12:37 PM To: Nabil Gergis Cc: Rahul Sharma MNUSHKIN, DMITRY Subject: RE: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI Hi Nabil, I am the committer but not the author of that change. Mnushkin, Dmitry wrote this code. I have now included him on this email chain. Thanks, Max Benjamin From: Nabil Gergis Sent: Wednesday, December 04, 2019 1:00 PM To: BENJAMIN, MAX BENJAMIN, MAX Cc: Rahul Sharma SMOKOWSKI, STEVEN Subject: ONAP: Creating 'Service Instance' again and again with same name, creates as many generic-vnf's objects under same service-instance object in AAI Dear Max, We submitted ONAP message, you can find it here: https://lists.onap.org/g/onap-discuss/message/19586 We looked at your commit here: https://gerrit.onap.org/r/c/so/+/92132/1/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflow/tasks/WorkflowAction.java#206, but looks like we are only allowing the call to fetch the details from AAI, if the request-action is 'CreateInstance'. Shouldn't it exit if there is an instance existing while you are trying to create another one with the same name? Are you trying to update existing Service instance? If yes, why you were not using 'UpdateInstance' Action instead of 'CreateInstance'? Best regards, Nabil Gergis -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19619): https://lists.onap.org/g/onap-discuss/message/19619 Mute This Topic: https://lists.onap.org/mt/64372322/21656 Mute #so: https://lists.onap.org/mk?hashtag=so&subid=2740164 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
