Christophe, Thank you for sharing, there is a wiki page for guidelines on implementing code coverage. Could you update that page when you get a chance?
https://wiki.onap.org/display/DW/Implementing+Code+Coverage I just recently updated it for Java sonar configuration changes but the Javascript isn’t there. Thanks! Pam From: <[email protected]> on behalf of "CLOSSET, CHRISTOPHE" <[email protected]> Reply-To: "[email protected]" <[email protected]>, "CLOSSET, CHRISTOPHE" <[email protected]> Date: Tuesday, January 28, 2020 at 9:06 AM To: "[email protected]" <[email protected]> Subject: [onap-discuss] Enabling JS in SonarCloud ***Security Advisory: This Message Originated Outside of AT&T *** Reference http://cso.att.com/EmailSecurity/IDSP.html for more information. All, We’ve been tweaking around with SonarCloud over the past few days to try and understand why our JS was no more analyzed VS what we had in SonarQube, Looking at SonarCloud ONAP projects, none were reporting JS https://sonarcloud.io/organizations/onap/projects<https://urldefense.proofpoint.com/v2/url?u=https-3A__sonarcloud.io_organizations_onap_projects&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=jwTiArcEj6aUX0HjV0M3dT12gUtk7rC07xpgpVZkS_4&m=I1y448-FS1iwJi2aLL8gZLfiYr5jEvUZgg1ArYYIRzs&s=FpFWEZCkv1_7wVu7F8MTk9RB51TNa5SK9ssCIMbGupw&e=>, so we suspected that there was something different. It seems that the SonarCloud Analyzer requires to have access to the executable of node.js on the build node to allow for the analysis to be run, not sure if this was the case before (apparently new since SQ 7.8). We have fixed it by pointing sonar to our own instance of node.js that we provide in our build (this way, we control the node.js version that we want). You can take a look at the CLAMP pom.xml<https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.onap.org_r_gitweb-3Fp-3Dclamp.git-3Ba-3Dblob-3Bf-3Dpom.xml&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=jwTiArcEj6aUX0HjV0M3dT12gUtk7rC07xpgpVZkS_4&m=I1y448-FS1iwJi2aLL8gZLfiYr5jEvUZgg1ArYYIRzs&s=9uAa0Hc1K-57ACowjbcToAAn67VcGnvhsA_NOs6RsB4&e=> file if you want to see how we’ve enabled it, also excluding test.js sources to properly report coverage. Hope it helps Regards Christophe -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19849): https://lists.onap.org/g/onap-discuss/message/19849 Mute This Topic: https://lists.onap.org/mt/70218540/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
