Hi Deng Hui, I've been working to switch modeling to use common mariadb instance and remove hardcoded passwords. That's why I had an opportunity to investigate modeling helm charts and source code.
During this work I discovered so many issues that I believe that in order to properly remove hardcoded passwords I'll need a help of your team. Below is the list of issues that I've discovered: 1) Modeling seems to have credentials to VFC redis database. Is it still used? If yes then it's a very bad practice as you shouldn't directly use DB of another micro service. If no then please remove dead piece of code 2) SDC credentials are hardcoded in the container image (BTW why you are using aai account to access SDC?) 3) genericpassword database credentials are hardcoded in container image 4) You create your database manually inside the container which means that you need a root password to that DB. You should use either mariadb-galera chart values or mariadb-init container for this purpose 5) You don't use init container but hardcode all the waiting for required resources in you docker entrypoint script which hardcodes the waiting time and other parameters 6) You should not modify your config files in the docker entrypoint script with sed. If this file is configurable it should reside in OOM repo and be pased to the container as a config map. I'd like to kindly ask you for help to fix those issues promptly. Best regards, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19876): https://lists.onap.org/g/onap-discuss/message/19876 Mute This Topic: https://lists.onap.org/mt/70826291/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
