Re: [onap-discuss] createReleaseDir.sh - is it ever used?

Mon, 17 Feb 2020 13:06:14 -0800 


On 17.02.2020 21:42, TIMONEY, DAN wrote:
> Krzysztof,
> 
> Sorry, I hadn’t remembered that script included default passwords.
> 
> Sure, we can remove that from the docker image, at least for now. Like I 
> said, that directory structure comes prewired in the docker image anyway.  
> When I get a chance and/or get a resource available to relook at that script, 
> we should really redesign it to make the passwords command line args so we 
> don’t have to hardcode them.

No worries. I'm just finishing a patch for OOM around dgbuilder so I'll 
just remove it.

> 
> Dan
> 
> On 2/17/20, 3:24 PM, "Krzysztof Opasiak" <[email protected]> wrote:
> 
>
>
>      On 17.02.2020 21:20, TIMONEY, DAN wrote:
>      > Krzysztof,
>      >
>      > I guess not, but I don't know that I see the harm?
>
>      So the harm is that this script contains number of passwords that I'm
>      trying to get rid of...
>
>      So if no one is using it I don't see too much sense reworking it to
>      extract them (passwords) instead of just simply removing the whole 
> script...
>
>      >
>      > Dan
>      >
>      > On 2/17/20, 2:25 PM, "Krzysztof Opasiak" <[email protected]> wrote:
>      >
>      >      Dan,
>      >
>      >      On 17.02.2020 20:14, TIMONEY, DAN wrote:
>      >      > Krzysztof,
>      >      >
>      >      > That script is a utility that sets up a skeleton directory 
> structure for dgbuilder to store the graphs you’re editing.  It’s not 
> terribly useful if you're running dgbuilder in a docker container, since the 
> docker container comes with a directory structure already set up for you.  
> However, if you wanted to build dgbuilder from source and run it outside a 
> docker container , you can set up multiple "release directories", so that it 
> you're working on multiple simultaneous development releases, you can keep 
> your DGs from each release in separate directories and then tell dgbuilder on 
> the command line which version you want to work with.
>      >
>      >      Hmm ok so it sound for me that it's perfectly valid to have it as 
> a
>      >      utility script in CCSDK source code but doesn't make too much 
> sens to
>      >      provide it to the dgbuilder container as it is never run inside 
> this
>      >      container right?
>      >
>      >      --
>      >      Krzysztof Opasiak
>      >      Samsung R&D Institute Poland
>      >      Samsung Electronics
>      >
>      >
>
>      --
>      Krzysztof Opasiak
>      Samsung R&D Institute Poland
>      Samsung Electronics
>
> 

-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#20047): https://lists.onap.org/g/onap-discuss/message/20047
Mute This Topic: https://lists.onap.org/mt/71355156/21656
Group Owner: [email protected]
Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-























					Reply via email to