Hello Jim and ONAP TSC, I would like to request a waiver from the TSC in El Alto release for Portal’s test coverage.
Facts: * After enabling Javascript (JS) coverage, the portal's coverage dropped from 72.9% to 21.6% - sonar link<https://sonar.onap.org/dashboard?id=org.onap.portal:onap-portal-parent>. Quality: * The team had a deep dive into the source code of Portal and we can see that the existing JUnit code covers most of critical functionalities of backend java code (72.9%). * Also, the robotframework tests cover all the functionalities end-to-end covering frontend and backend code. So I believe the quality of source code is still in good shape. Risk/Benefit: * This is a huge drop, as the project contain good amount of Javascript code. * The risk here is team may not achieve 55% coverage with JS in El Alto – listed as risk here<https://wiki.onap.org/display/DW/El-Alto+Risks>. Plan forward: * The team is planning to upgrade to latest Angular 6 which is in Typescript (rather than in Javascript), along with this new upgrade. * The team will explore the test coverage process for typescript code and request LF support to enable Typescript support in ONAP’s Sonar. * So, the recommendation is not to invest efforts in adding code coverage for old JS code, rather invest in typescript code. * For El Alto, it is recommended to disable JS code coverage and start enabling coverage for typescript code. * However, achieving 55% code coverage in new Typescript code is aggressive for El Alto release. The team can target for Frankfurt release. Regards Manoop Talasila ONAP PORTAL PTL -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5333): https://lists.onap.org/g/onap-tsc/message/5333 Mute This Topic: https://lists.onap.org/mt/32799688/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-tsc/leave/2743226/1412191262/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
