Hello TSC Members, Awhile back Catherine, Bell Canada, and I met to discuss Bell Canada's desire to contribute a concurrency bugfix to the Frankfurt branch on a few AAI microservices (They are planning on upgrading to Frankfurt internally). We have worked through the code with them and the commit is raised to the Frankfurt branch.
Just wanted to double check that this is ok to merge and then follow the self-release process outlined here: https://wiki.onap.org/display/DW/Self+Release+Workflow Thanks, William Reehil Principal Member of Technical Staff | A&AI ONAP PTL AT&T ECOMP PLATFORM AND SYSTEMS (C) 732 865-5333 | (O) 732 420-7806 From: Prudence Au <[email protected]> Sent: Wednesday, September 30, 2020 8:58 AM To: KAJUR, HARISH V <[email protected]>; Kuldip Rai <[email protected]>; REEHIL, WILLIAM E <[email protected]>; MAHARAJH, ROBBY <[email protected]> Cc: Niharika Sharma (95690) <[email protected]>; Suresh Charan <[email protected]>; Michael Pruss <[email protected]>; Mike Elliott <[email protected]>; Vezeau, Martin <[email protected]> Subject: Re: Concurrency fix in SchemaGenerator.java - discussion/update Hi Harish, Thanks for your prompt reply. At Bell, we are currently working on upgrading to the Frankfurt release and this fix is needed. @REEHIL, WILLIAM E<mailto:[email protected]>, @KAJUR, HARISH V<mailto:[email protected]> can you please suggest how we can have this fix available for the Frankfurt maintenance release so that we can consume it at Bell? Thanks, Prudence ________________________________ From: KAJUR, HARISH V <[email protected]<mailto:[email protected]>> Sent: September 30, 2020 12:21 AM To: Kuldip Rai <[email protected]<mailto:[email protected]>>; REEHIL, WILLIAM E <[email protected]<mailto:[email protected]>>; MAHARAJH, ROBBY <[email protected]<mailto:[email protected]>> Cc: Prudence Au <[email protected]<mailto:[email protected]>>; Niharika Sharma (95690) <[email protected]<mailto:[email protected]>>; Suresh Charan <[email protected]<mailto:[email protected]>>; Michael Pruss <[email protected]<mailto:[email protected]>>; Mike Elliott <[email protected]<mailto:[email protected]>>; Vezeau, Martin <[email protected]<mailto:[email protected]>> Subject: RE: Concurrency fix in SchemaGenerator.java - discussion/update Hi Kuldip, The unit test failing has nothing to do with your change but an spring unit test context issue. It is failing because spring context has been closed and it needs to be re-initialized before the start of this test, using annotation @DirtiesContext(classMode = DirtiesContext.ClassMode.BEFORE_CLASS). Once you do this change, if you notice any other test failing, try adding this annotation to that unit test as well. It was due to one of the unit test is closing the spring context and we haven't found the original unit test that originally caused this so when we encounter this issue, we would add that annotation to recreate the context to the failing unit test. Having said that, I see you are committing this change to Frankfurt, since Frankfurt is officially released, I don't think we can merge any changes to that branch without TSC approval. Thanks, Harish From: Kuldip Rai <[email protected]<mailto:[email protected]>> Sent: Tuesday, September 29, 2020 4:27 PM To: KAJUR, HARISH V <[email protected]<mailto:[email protected]>>; REEHIL, WILLIAM E <[email protected]<mailto:[email protected]>>; MAHARAJH, ROBBY <[email protected]<mailto:[email protected]>> Cc: Prudence Au <[email protected]<mailto:[email protected]>>; Niharika Sharma (95690) <[email protected]<mailto:[email protected]>>; Suresh Charan <[email protected]<mailto:[email protected]>>; Michael Pruss <[email protected]<mailto:[email protected]>>; Mike Elliott <[email protected]<mailto:[email protected]>>; Vezeau, Martin <[email protected]<mailto:[email protected]>> Subject: Re: Concurrency fix in SchemaGenerator.java - discussion/update Hello Harish, Code with config flag was tested successfully locally, review was created and submitted. However build has failed due to one test case which did not fail locally. https://jenkins.onap.org/job/aai-aai-common-frankfurt-verify-java/10/consoleFull#-1488441298bcfdded6-02ae-476c-9df0-36a49e72fd2c<https://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Furldefense.com*2Fv3*2F__https*3A*2Fjenkins.onap.org*2Fjob*2Faai-aai-common-frankfurt-verify-java*2F10*2FconsoleFull*-1488441298bcfdded6-02ae-476c-9df0-36a49e72fd2c__*3BIw!!BhdT!1uGrgyY-T2JwmG2_ggcpdojBs3RkTFPh2qLlK2XR2Kw5G8r2S7UvWhaLiIo4GQ*24&data=02*7C01*7CPrudence.Au*40amdocs.com*7Ccba48d86b09c43e9522608d864f889b3*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637370365922668733&sdata=C9xWpKrJBFz3LsMBuu7JGS9LbLMaw*2F3H4NAqccaH9Kg*3D&reserved=0__;JSUlJSUlJSUlJSUqJSUlJSUlJSUlJSUl!!BhdT!y5JBQXFldj1VwVOt9qMCGK8eJqqehdBVoAtxaukYghFUVm4uABUPpE784EOFmg$> 5:43:51 [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 s <<< FAILURE! - in org.onap.aai.parsers.uri.URIToExtensionInformationTest 15:43:51 [ERROR] org.onap.aai.parsers.uri.URIToExtensionInformationTest.vserversV8 Time elapsed: 0.028 s <<< ERROR! 15:43:51 org.onap.aai.exceptions.AAIException: java.lang.IllegalStateException: org.springframework.context.support.GenericApplicationContext@741d9cff<mailto:org.springframework.context.support.GenericApplicationContext@741d9cff> has been closed already 15:43:51 at org.onap.aai.parsers.uri.URIToExtensionInformationTest.vserversV8(URIToExtensionInformationTest.java:64) 15:43:51 Caused by: java.lang.IllegalStateException: org.springframework.context.support.GenericApplicationContext@741d9cff<mailto:org.springframework.context.support.GenericApplicationContext@741d9cff> has been closed already 15:43:51 at org.onap.aai.parsers.uri.URIToExtensionInformationTest.vserversV8(URIToExtensionInformationTest.java:64) 15:43:51 15:43:51 [INFO] Running org.onap.aai.parsers.uri.URIToObjectTest Having said that this jenkin build test case failure does not seems to be related to this code change. Any idea please? Thank you very much in advance, Kuldip singh From: "KAJUR, HARISH V" <[email protected]<mailto:[email protected]>> Date: Thursday, September 17, 2020 at 11:13 PM To: Kuldip Rai <[email protected]<mailto:[email protected]>>, "REEHIL, WILLIAM E" <[email protected]<mailto:[email protected]>>, "MAHARAJH, ROBBY" <[email protected]<mailto:[email protected]>> Cc: Prudence Au <[email protected]<mailto:[email protected]>>, "Niharika Sharma (95690)" <[email protected]<mailto:[email protected]>>, Suresh Charan <[email protected]<mailto:[email protected]>>, Michael Pruss <[email protected]<mailto:[email protected]>>, Mike Elliott <[email protected]<mailto:[email protected]>>, "Vezeau, Martin" <[email protected]<mailto:[email protected]>> Subject: RE: Concurrency fix in SchemaGenerator.java - discussion/update + Bill Reehil, +Robby Hi Kuldip, I don't think we need an unit test for this change as its an functionality provided by the janusgraph itself. The important thing that I do want to note is we want this change to be configurable and be defaulted to false. In the helm chart, we can make it configurable where the deployer can add it to their override file to enable lock on the uris. For the schema creation code where you are adding the lock, something like this where you are writing the lock would be required: if("true".equals(AAIConfig.get("aai.lock.uri.enabled", "false"))){ } Also, which release are you planning on contributing this to because guilin code freeze is today? Thanks, Harish From: Kuldip Rai <[email protected]<mailto:[email protected]>> Sent: Wednesday, September 16, 2020 12:54 PM To: KAJUR, HARISH V <[email protected]<mailto:[email protected]>> Cc: Prudence Au <[email protected]<mailto:[email protected]>>; Niharika Sharma (95690) <[email protected]<mailto:[email protected]>>; Suresh Charan <[email protected]<mailto:[email protected]>>; Michael Pruss <[email protected]<mailto:[email protected]>>; Mike Elliott <[email protected]<mailto:[email protected]>>; Vezeau, Martin <[email protected]<mailto:[email protected]>> Subject: Re: Concurrency fix in SchemaGenerator.java - discussion/update Hi Harish, Ref: Fix: concurrency fix in SchemaGenerator.java Release: Frankfurt Test case: create pnf via rest call http://{{onap}}:{{aai-port}}/aai/v14/network/pnfs/pnf/fra-qa-pnf-concurrency-fix-test-<xxxxx><https://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Furldefense.com*2Fv3*2F__https*3A*2Feur01.safelinks.protection.outlook.com*2F*3Furl*3Dhttps*3A*2F*2Furldefense.proofpoint.com*2Fv2*2Furl*3Fu*3Dhttp-3A__-257B-257Bonap-257D-257D-3A-257B-257Baai-2Dport-257D-257D_aai_v14_network_pnfs_pnf_fra-2Dqa-2Dpnf-2Dconcurrency-2Dfix-2Dtest-2D-253Cxxxxx-253E*26d*3DDwQGaQ*26c*3DLFYZ-o9_HUMeMTSQicvjIg*26r*3Df44eG3iZaja2ozEA2yRZnQ*26m*3DY5ukEBWfigNpGwQ4ku60eqpf7mhbZeS3_-cbFibzWrc*26s*3DHQqMTo_sJn0h-2DH5U609_DcXYEbAnF5ZP33GtYpD1w*26e*3D*26data*3D02*7C01*7CKuldip.Rai*40amdocs.com*7C6712d09c94994734c5b208d85b80d768*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637359956230485302*26sdata*3DTqAcGPVDoVx9tyjsZMrb222*2FxZ3vuxpZAauoGm23yBA*3D*26reserved*3D0__*3BJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSU!!BhdT!1uGrgyY-T2JwmG2_ggcpdojBs3RkTFPh2qLlK2XR2Kw5G8r2S7UvWhbzylAKEA*24&data=02*7C01*7CPrudence.Au*40amdocs.com*7Ccba48d86b09c43e9522608d864f889b3*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637370365922678731&sdata=F5FUwq6WIEZlVgGk8Zcrgb*2Fo9Fb3RebLX3MSrhPbGZ0*3D&reserved=0__;JSUlJSUlJSUlJSoqKioqKioqKioqKioqKioqKiolJSoqKioqKioqJSUqKiUlJSUlJSUlJSUlJSUl!!BhdT!y5JBQXFldj1VwVOt9qMCGK8eJqqehdBVoAtxaukYghFUVm4uABUPpE7CPL0rXg$> Status: Passed. Further to our meeting with you and as per your suggestion to deploy the fix on graphadmin pod, we are pleased to inform that the fix worked as expected. As part of our multiple testing scenarios, no duplicates pnfs were reported. Now before we submit the fix , we would like to get your input on the following: 1. Is there any specific test case(s) that needs to be handled/written before submission will be allowed? 2. Specific location for these test cases if needed? 3. Needed env and how to make them run? 4. Anything else you may want to add here? Thanks, Kuldip singh and team. From: Kuldip Rai <[email protected]<mailto:[email protected]>> Date: Tuesday, September 8, 2020 at 9:17 AM To: "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Cc: Prudence Au <[email protected]<mailto:[email protected]>>, "Niharika Sharma (95690)" <[email protected]<mailto:[email protected]>>, Suresh Charan <[email protected]<mailto:[email protected]>>, Michael Pruss <[email protected]<mailto:[email protected]>>, Mike Elliott <[email protected]<mailto:[email protected]>> Subject: Concurrency fix in SchemaGenerator.java - discussion/update Hello Venkata, As per your comments to the review https://gerrit.onap.org/r/c/aai/resources/+/110936<https://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Furldefense.com*2Fv3*2F__https*3A*2Feur01.safelinks.protection.outlook.com*2F*3Furl*3Dhttps*3A*2F*2Furldefense.proofpoint.com*2Fv2*2Furl*3Fu*3Dhttps-3A__gerrit.onap.org_r_c_aai_resources_-2B_110936*26d*3DDwMGaQ*26c*3DLFYZ-o9_HUMeMTSQicvjIg*26r*3Df44eG3iZaja2ozEA2yRZnQ*26m*3DY5ukEBWfigNpGwQ4ku60eqpf7mhbZeS3_-cbFibzWrc*26s*3D9dRxZH6U5uOPBEVTb8jkiaP76Wsoz5SwjPrfU2LRRzg*26e*3D*26data*3D02*7C01*7CKuldip.Rai*40amdocs.com*7C6712d09c94994734c5b208d85b80d768*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637359956230485302*26sdata*3DURWku9hvIj9dEQBG*2F9p3Ytq0SWAA9oOPFRkHTRq7RRE*3D*26reserved*3D0__*3BJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSU!!BhdT!1uGrgyY-T2JwmG2_ggcpdojBs3RkTFPh2qLlK2XR2Kw5G8r2S7UvWhbRBNUwgA*24&data=02*7C01*7CPrudence.Au*40amdocs.com*7Ccba48d86b09c43e9522608d864f889b3*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637370365922688725&sdata=fRg7Fwdm43cUgDeuwg4bbqu0JIFzjww2Cg*2FYUbZW8fE*3D&reserved=0__;JSUlJSUlJSUlJSoqKioqKioqKioqKioqKioqKiolJSoqKioqKioqJSUqKiUlJSUlJSUlJSUlJSUl!!BhdT!y5JBQXFldj1VwVOt9qMCGK8eJqqehdBVoAtxaukYghFUVm4uABUPpE7D9kb87A$> about the suggested concurrency fix in SchemaGenerator.java class. Fix tested in release: Frankfurt Test case: create pnf via rest call http://{{onap}}:{{aai-port}}/aai/v14/network/pnfs/pnf/fra-qa-pnf-concurrency-fix-test-2<https://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Furldefense.com*2Fv3*2F__https*3A*2Feur01.safelinks.protection.outlook.com*2F*3Furl*3Dhttps*3A*2F*2Furldefense.proofpoint.com*2Fv2*2Furl*3Fu*3Dhttp-3A__-257B-257Bonap-257D-257D-3A-257B-257Baai-2Dport-257D-257D_aai_v14_network_pnfs_pnf_fra-2Dqa-2Dpnf-2Dconcurrency-2Dfix-2Dtest-2D2*26d*3DDwQGaQ*26c*3DLFYZ-o9_HUMeMTSQicvjIg*26r*3Df44eG3iZaja2ozEA2yRZnQ*26m*3DY5ukEBWfigNpGwQ4ku60eqpf7mhbZeS3_-cbFibzWrc*26s*3DuBXQXSjCx-tJfPE22oixLRbbogRUGEOHCZrFZs4j7TY*26e*3D*26data*3D02*7C01*7CKuldip.Rai*40amdocs.com*7C6712d09c94994734c5b208d85b80d768*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637359956230495299*26sdata*3DrV4hJufKjXhS2*2BhvOt9FXD23OaVryb6*2F2HnOxxdnhmQ*3D*26reserved*3D0__*3BJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUl!!BhdT!1uGrgyY-T2JwmG2_ggcpdojBs3RkTFPh2qLlK2XR2Kw5G8r2S7UvWhbYavRjKA*24&data=02*7C01*7CPrudence.Au*40amdocs.com*7Ccba48d86b09c43e9522608d864f889b3*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637370365922688725&sdata=PsCkc9OYFfX7Yld08n*2B*2FkMT*2F95QYE*2BRC1QeJYmK3*2Fkk*3D&reserved=0__;JSUlJSUlJSUlJSoqKioqKioqKioqKioqKioqKiolJSoqKioqKioqJSUqKiolJSUlJSUlJSUlJSUlJSUlJSU!!BhdT!y5JBQXFldj1VwVOt9qMCGK8eJqqehdBVoAtxaukYghFUVm4uABUPpE4oPx9tGw$> Status: failed (see below) During local testing, it was discovered that execution path does not involve SchemaGenerator.java class and thus fix did NOT get executed and issue was not resolved. Execution path: LegacyMoxyConsumer::handleWrites() --> HttpEntry::process() -->DBSerializer::createNewVertex() and ::serializeToDb () It uses the JanusGraph library. Is it possible to setup a meeting to discuss this issue further to get better understanding and next step forward? Thank you very much in advance, kuldip singh and team. This email and the information contained herein is proprietary and confidential and subject to the Amdocs Email Terms of Service, which you may review at https://www.amdocs.com/about/email-terms-of-service<https://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Furldefense.com*2Fv3*2F__https*3A*2Feur01.safelinks.protection.outlook.com*2F*3Furl*3Dhttps*3A*2F*2Furldefense.proofpoint.com*2Fv2*2Furl*3Fu*3Dhttps-3A__www.amdocs.com_about_email-2Dterms-2Dof-2Dservice*26d*3DDwMGaQ*26c*3DLFYZ-o9_HUMeMTSQicvjIg*26r*3Df44eG3iZaja2ozEA2yRZnQ*26m*3DY5ukEBWfigNpGwQ4ku60eqpf7mhbZeS3_-cbFibzWrc*26s*3DR5eq6762KHg7W-xdu0v72Qx3cAEV0cDhM-_6S8vSvC0*26e*3D*26data*3D02*7C01*7CKuldip.Rai*40amdocs.com*7C6712d09c94994734c5b208d85b80d768*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637359956230495299*26sdata*3DN7R5QsrpQVZf3aFmGP3eKOviWoCTIdLD8gVphWaKY3o*3D*26reserved*3D0__*3BJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJQ!!BhdT!1uGrgyY-T2JwmG2_ggcpdojBs3RkTFPh2qLlK2XR2Kw5G8r2S7UvWhYgym8Idw*24&data=02*7C01*7CPrudence.Au*40amdocs.com*7Ccba48d86b09c43e9522608d864f889b3*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637370365922698718&sdata=gtxMBGlZR3Cgp1YJtIXY8q1H55LS9QMZyy2uUg9h8Yk*3D&reserved=0__;JSUlJSUlJSUlJSoqKioqKioqKioqKioqKioqKiolJSoqKioqKioqJSUqJSUlJSUlJSUlJSUlJQ!!BhdT!y5JBQXFldj1VwVOt9qMCGK8eJqqehdBVoAtxaukYghFUVm4uABUPpE7sILonDg$> This email and the information contained herein is proprietary and confidential and subject to the Amdocs Email Terms of Service, which you may review at https://www.amdocs.com/about/email-terms-of-service<https://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Furldefense.com*2Fv3*2F__https*3A*2Fwww.amdocs.com*2Fabout*2Femail-terms-of-service__*3B!!BhdT!1uGrgyY-T2JwmG2_ggcpdojBs3RkTFPh2qLlK2XR2Kw5G8r2S7UvWhY4K2-mtA*24&data=02*7C01*7CPrudence.Au*40amdocs.com*7Ccba48d86b09c43e9522608d864f889b3*7Cc8eca3ca127646d59d9da0f2a028920f*7C0*7C0*7C637370365922698718&sdata=e5IMq5RUDR9*2BMih6g3zsPpYdwLcbGkrVidFFT9ifxew*3D&reserved=0__;JSUlJSUlJSUlJSUlJSUlJSUlJSUl!!BhdT!y5JBQXFldj1VwVOt9qMCGK8eJqqehdBVoAtxaukYghFUVm4uABUPpE4nmhTxmA$> This email and the information contained herein is proprietary and confidential and subject to the Amdocs Email Terms of Service, which you may review at https://www.amdocs.com/about/email-terms-of-service<https://urldefense.com/v3/__https:/www.amdocs.com/about/email-terms-of-service__;!!BhdT!y5JBQXFldj1VwVOt9qMCGK8eJqqehdBVoAtxaukYghFUVm4uABUPpE5TIRWJ9g$> -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#7128): https://lists.onap.org/g/onap-tsc/message/7128 Mute This Topic: https://lists.onap.org/mt/77225630/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-tsc/leave/2743226/1412191262/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
