Hello again,

I am working to have the ooh323 channel driver provide early audio before the call answer. I am going through the code to understand where and how the opening of RTP is controled, but being a not very experienced C programmer the process of understanding the code is rather slow...

So I wanted to ask if there is anyone on this list who has done already some work towards establishing early audio, before the call answer. I would be interested to put some effort in this...

Best regards,
Vlasis Hatzistavrou.


Vlasis Hatzistavrou - asterisk mailing list account wrote:

Hello,

A couple of weeks ago we noticed that when the called number contained one or more #'s, the called number would appear empty.

We found the problem in chan_h323.c in function:

int onNewCallCreated(ooCallData *call)

We see the block of code:

     if(p->callerid_num)
     {
        i=0;
        while(*(p->callerid_num+i) != '\0')
        {
           if(!isdigit(*(p->callerid_num+i)))
              break;
           i++;
        }
        if(*(p->callerid_num+i) == '\0')
           ooCallSetCallingPartyNumber(call, p->callerid_num);
        else{
           if(!p->callerid_name)
              ooCallSetCallerId(call, p->callerid_num);
        }
     }


If this is changed to:


     if(p->callerid_num)
     {
        i=0;
        while(*(p->callerid_num+i) != '\0')
        {
           if( (!isdigit(*(p->exten+i))) && (!(*(p->exten+i)=='#')) )
              break;
           i++;
        }
        if(*(p->callerid_num+i) == '\0')
           ooCallSetCallingPartyNumber(call, p->callerid_num);
        else{
           if(!p->callerid_name)
              ooCallSetCallerId(call, p->callerid_num);
        }
     }

the # digit is allowed. We've seen simliar parts of code for finding out which is the caller id of the call. Perhaps this fix should be applied to the caller ID code also?

Best regards,
Vlasis Hatzistavrou.





-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
ooh323c-devel mailing list
ooh323c-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ooh323c-devel

Reply via email to