Hi Vlasis,
Did you mean p->callerid_num instead of p->extern, As we are setting value
from p->callerid_num at your suggested change line:
if( (!isdigit(*(p->callerid_num+i))) &&
(!(*(p->callerid_num+i)=='#')) )
instead of
> if( (!isdigit(*(p->exten+i))) && (!(*(p->exten+i)=='#')) )
The p->extern is used for setting the dialedDigit/h323ID.
Thank you for your changes.
Regards,
Avin Patel
Objective Systems, Inc.
> -----Original Message-----
> From: Vlasis Hatzistavrou - asterisk mailing list account
> [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, January 31, 2006 7:09 AM
> To: ooh323c-devel@lists.sourceforge.net
> Subject: [ooh323c-devel] Fix for # digit in dialed numbers
>
>
> Hello,
>
> A couple of weeks ago we noticed that when the called number contained
> one or more #'s, the called number would appear empty.
>
> We found the problem in chan_h323.c in function:
>
> int onNewCallCreated(ooCallData *call)
>
> We see the block of code:
>
> if(p->callerid_num)
> {
> i=0;
> while(*(p->callerid_num+i) != '\0')
> {
> if(!isdigit(*(p->callerid_num+i)))
> break;
> i++;
> }
> if(*(p->callerid_num+i) == '\0')
> ooCallSetCallingPartyNumber(call, p->callerid_num);
> else{
> if(!p->callerid_name)
> ooCallSetCallerId(call, p->callerid_num);
> }
> }
>
>
> If this is changed to:
>
>
> if(p->callerid_num)
> {
> i=0;
> while(*(p->callerid_num+i) != '\0')
> {
> if( (!isdigit(*(p->exten+i))) && (!(*(p->exten+i)=='#')) )
> break;
> i++;
> }
> if(*(p->callerid_num+i) == '\0')
> ooCallSetCallingPartyNumber(call, p->callerid_num);
> else{
> if(!p->callerid_name)
> ooCallSetCallerId(call, p->callerid_num);
> }
> }
>
> the # digit is allowed. We've seen simliar parts of code for finding out
> which is the caller id of the call. Perhaps this fix should be applied
> to the caller ID code also?
>
> Best regards,
> Vlasis Hatzistavrou.
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep
> through log files
> for problems? Stop! Download the new AJAX search engine that makes
> searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> _______________________________________________
> ooh323c-devel mailing list
> ooh323c-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ooh323c-devel
>
>
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
ooh323c-devel mailing list
ooh323c-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ooh323c-devel
